When code was added to better handle invisible key or time signatures
at the beginning of a score,
this inadvertently affected spacing between barline and first note
if there were invisible key or time signature changes later.
The spacing was never actually *correct* here -
it was controlled by the key or time signature margin -
but it more or less worked and scores depended on it.
The problem is that the changes made involved
setitng the width of these invisible segments to 0
and skipping them.
Whereas previously, they got processed enough
to yield some space betwene the barline and first note.
The firx here is just to limit the effect of the previous change
so not *all* segments with all elements invisible,
but only those in system header measures,
or segments after the beginning of the measure.
Thus we continue to handle beginnings of scores and systems well,
and also courtesies at the end of measures.
But we revert to the previous behavior for key or time signatures
at the beginning of measures that are *not* headers.
Again, it wasn't ideal, but it basically worked,
nand now works again the same way.
I left TODO's in the code to indicate something
of what would need to happen to fix this "for real",
with the space controlled by barNoteDistance as the user expects,
rather than depending on the key or time signature margins.
A quick attempt to implement this led to problems
that convinced me to put it off until a larger scale rewrite
of the spacing algorithms as a whole.
In #5432, Score::undoChangeSpannerElements() was modified to allow for changing one or both of the elements to or from nullptr. However, in the case of a linked spanner, where we have to look for parallel elements in another track, we cannot use the track of the old spanner elements if they are null. A default track of 0 was arbitrarily chosen in this case, but that causes the spanner to be attached to the wrong staff. Fortunately, we can use the spanner's track() and track2() functions even if its elements are null.
9d92698...
by
Casper Jeukendrup <email address hidden>
Change cursor shape to Pointing Hand when hovering link in QML
With specifically in mind the link to the 3.6 announcement video in the Score Migration Dialog.
6d72f5d...
by
Casper Jeukendrup <email address hidden>
Fix Style Import Dialog when using Restore Session
afd77df...
by
Casper Jeukendrup <email address hidden>
Fix #315237: Don't switch tab when opening a score when a modal is open
- Don't switch tab when opening a score when a modal is open
- Make ScoreMigrationDialog QQuickWidget, so that it gets recognized by QApplication::activeModalWidget()
- (This caused an issue that the QML content wasn't focussed when the dialog was opened, which I fixed too.)
Result:
- When you open one score, it is appended to the tab bar, and its tab is activated
- The ScoreMigrationDialog for that score is shown
- When you open a second score, it is appended to the tab bar, but its tab is not activated, because a modal dialog is open (namely the ScoreMigrationDialog for score 1)
- When you close the dialog for score 1 and then switch to score 2 's tab, the ScoreMigrationDialog is shown for score 2.
