Merge ~mschiu77/ubuntu/+source/firmware-sof:ubuntu/noble-devel into ubuntu/+source/firmware-sof:ubuntu/noble-devel

Proposed by Chris Chiu
Status: Needs review
Proposed branch: ~mschiu77/ubuntu/+source/firmware-sof:ubuntu/noble-devel
Merge into: ubuntu/+source/firmware-sof:ubuntu/noble-devel
Diff against target: 190 lines
Reviewer Review Type Date Requested Status
Lukas Märdian (community) Abstain
Vladimir Petko (community) Approve
You-Sheng Yang (community) Approve
Canonical Kernel Pending
Ubuntu Kernel Team Pending
git-ubuntu import Pending
Review via email: mp+474998@code.launchpad.net

Commit message

This requires following firmware blobs:
* linux-firmware
  - https://github.com/CirrusLogic/linux-firmware/commit/367fda8e56d7dda4c138438493e2bf6b9b92ce7b
* firmware-sof
  - sof-lnl-cs42l43-l0.tplg and the corresponding Intel firmware sof-lnl.ri

To post a comment you must log in.
Revision history for this message
You-Sheng Yang (vicamo) wrote :
review: Needs Fixing
Revision history for this message
Chris Chiu (mschiu77) wrote :

Fix the patch to add the sof-ipc4-lib back per requested.

Revision history for this message
Chris Chiu (mschiu77) wrote :

Fix the `Origin` url per requested

Revision history for this message
You-Sheng Yang (vicamo) wrote :

LGTM.

review: Approve
Revision history for this message
Julian Andres Klode (juliank) wrote :

This isn't particularly easy to sponsor, as there's no easy way to check that the patch included is the same one as upstream, as this adds binaries, which are not particularly supported in patches, and the git patch format for binaries is different.

Hence I'd need to grab the upstream patch, apply it, record hashes, apply this patch, record hashes, and this seems very time intense, so I'll not review any of the firmware-sof patches in this patch pilot round, sorry.

Revision history for this message
Vladimir Petko (vpa1977) wrote :

Validated against upstream/plucky.

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading firmware-sof_2023.12.1-1ubuntu1.2.dsc: done.
  Uploading firmware-sof_2023.12.1-1ubuntu1.2.debian.tar.xz: done.
  Uploading firmware-sof_2023.12.1-1ubuntu1.2_source.buildinfo: done.
  Uploading firmware-sof_2023.12.1-1ubuntu1.2_source.changes: done.
Successfully uploaded packages.

review: Approve
Revision history for this message
Anthony Wong (anthonywong) wrote :

This MR has been merged to Noble and package has already been released.

Revision history for this message
Lukas Märdian (slyon) wrote :

Already sponsored, as stated in the comment before. Removing ~ubuntu-sponsors.

review: Abstain

Unmerged commits

b38ce37... by Chris Chiu

2023.12.1-1ubuntu1.2 (patches unapplied)

Imported using git-ubuntu import.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 0fdeab4..69660c8 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
1firmware-sof (2023.12.1-1ubuntu1.2) noble; urgency=medium
2
3 * Missing CS35L56 sof firmware for Dell Bolan platform. (LP: #2077829)
4 - Add 2.11 topology2 production binaries
5 - Add SOF v2.11.1 signed Intel binaries for MTL/LNL/ARL
6
7 -- Chris Chiu <chris.chiu@canonical.com> Mon, 14 Oct 2024 15:50:54 +0800
8
1firmware-sof (2023.12.1-1ubuntu1.1) noble; urgency=medium9firmware-sof (2023.12.1-1ubuntu1.1) noble; urgency=medium
210
3 * Soundwire support for CS42L43 and CS35L56 on Intel MTL. (LP: #2069760)11 * Soundwire support for CS42L43 and CS35L56 on Intel MTL. (LP: #2069760)
diff --git a/debian/patches/0003-Add-2.11-topology2-production-binaries.patch b/debian/patches/0003-Add-2.11-topology2-production-binaries.patch
4new file mode 10064412new file mode 100644
index 0000000..6b857f8
--- /dev/null
+++ b/debian/patches/0003-Add-2.11-topology2-production-binaries.patch
@@ -0,0 +1,10719 @@
1From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
2Date: Mon, 23 Sep 2024 14:12:38 +0300
3Subject: [PATCH] Add 2.11 topology2 production binaries
4
5Add binaries for all production topology2 binaries.
6
7Generated with Intel SOF build, identification "Build #5357".
8
9Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
10Origin: backport, https://github.com/thesofproject/sof-bin/commit/72d761ef5503e0779f3b57d180dcd2383e75efa4.patch
11Bug-Ubuntu: https://bugs.launchpad.net/bugs/2077829
12Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
13---
14 .../sof-adl-cs42l43-l0-cs35l56-l23.tplg | Bin 0 -> 48766 bytes
15 .../sof-ipc4-tplg-v2.11/sof-adl-rt711-4ch.tplg | Bin 0 -> 51555 bytes
16 .../sof-adl-rt711-l0-rt1308-l12-rt715-l3.tplg | Bin 0 -> 48766 bytes
17 .../sof-adl-rt711-l0-rt1316-l12-rt714-l3.tplg | Bin 0 -> 54150 bytes
18 .../sof-adl-rt711-l0-rt1316-l13-rt714-l2.tplg | Bin 0 -> 54150 bytes
19 .../sof-arl-cs42l43-l0-cs35l56-l2.tplg | Bin 0 -> 47378 bytes
20 .../sof-arl-cs42l43-l0-cs35l56-l23.tplg | Bin 0 -> 48766 bytes
21 .../sof-ipc4-tplg-v2.11/sof-arl-cs42l43-l0.tplg | Bin 0 -> 47378 bytes
22 .../sof-arl-cs42l43-l2-cs35l56-l3.tplg | Bin 0 -> 47378 bytes
23 .../sof-ipc4-tplg-v2.11/sof-arl-cs42l43-l2.tplg | Bin 0 -> 47378 bytes
24 .../sof-hda-generic-2ch.tplg | Bin 0 -> 58374 bytes
25 .../sof-hda-generic-4ch.tplg | Bin 0 -> 57758 bytes
26 .../sof-hda-generic-ace1-2ch.tplg | Bin 0 -> 64595 bytes
27 .../sof-hda-generic-ace1-4ch.tplg | Bin 0 -> 63979 bytes
28 .../sof-hda-generic-ace1-idisp-2ch.tplg | Bin 0 -> 36267 bytes
29 .../sof-hda-generic-ace1-idisp-4ch.tplg | Bin 0 -> 36267 bytes
30 .../sof-hda-generic-cavs25-2ch.tplg | Bin 0 -> 64595 bytes
31 .../sof-hda-generic-cavs25-4ch.tplg | Bin 0 -> 63979 bytes
32 .../sof-hda-generic-cavs25-idisp-2ch.tplg | Bin 0 -> 36267 bytes
33 .../sof-hda-generic-cavs25-idisp-4ch.tplg | Bin 0 -> 36267 bytes
34 .../sof-hda-generic-idisp-2ch.tplg | Bin 0 -> 30046 bytes
35 .../sof-hda-generic-idisp-4ch.tplg | Bin 0 -> 30046 bytes
36 .../sof-hda-generic-idisp.tplg | Bin 0 -> 18130 bytes
37 .../sof-ipc4-tplg-v2.11/sof-hda-generic.tplg | Bin 0 -> 45774 bytes
38 .../sof-ipc4-tplg-v2.11/sof-imx8mp-wm8960.tplg | Bin 0 -> 4158 bytes
39 .../sof-lnl-cs42l43-l0-cs35l56-l23.tplg | Bin 0 -> 48766 bytes
40 .../sof-lnl-cs42l43-l0-cs35l56-l3.tplg | Bin 0 -> 47378 bytes
41 .../sof-ipc4-tplg-v2.11/sof-lnl-cs42l43-l0.tplg | Bin 0 -> 47378 bytes
42 .../sof-lnl-rt1318-l12-rt714-l0.tplg | Bin 0 -> 36126 bytes
43 .../sof-ipc4-tplg-v2.11/sof-lnl-rt711-4ch.tplg | Bin 0 -> 51555 bytes
44 .../sof-lnl-rt711-l0-rt1316-l23-rt714-l1.tplg | Bin 0 -> 54150 bytes
45 .../sof-lnl-rt712-l2-rt1712-l3.tplg | Bin 0 -> 47378 bytes
46 .../sof-ipc4-tplg-v2.11/sof-lnl-rt722-l0.tplg | Bin 0 -> 47378 bytes
47 .../sof-mtl-cs42l43-l0-cs35l56-l12.tplg | Bin 0 -> 54150 bytes
48 .../sof-mtl-cs42l43-l0-cs35l56-l23.tplg | Bin 0 -> 48766 bytes
49 .../sof-ipc4-tplg-v2.11/sof-mtl-cs42l43-l0.tplg | Bin 0 -> 47378 bytes
50 .../sof-mtl-es83x6-ssp1-hdmi-ssp02.tplg | Bin 0 -> 36881 bytes
51 .../sof-ipc4-tplg-v2.11/sof-mtl-hdmi-ssp02.tplg | Bin 0 -> 26325 bytes
52 .../sof-mtl-max98357a-rt5682-google-aec.tplg | Bin 0 -> 79803 bytes
53 ...7a-rt5682-ssp2-ssp0-2ch-pdm1-google-aec.tplg | Bin 0 -> 83587 bytes
54 ...mtl-max98357a-rt5682-ssp2-ssp0-2ch-pdm1.tplg | Bin 0 -> 73167 bytes
55 ...l-max98357a-rt5682-ssp2-ssp0-google-aec.tplg | Bin 0 -> 83587 bytes
56 .../sof-mtl-max98357a-rt5682-ssp2-ssp0.tplg | Bin 0 -> 73167 bytes
57 .../sof-mtl-max98357a-rt5682.tplg | Bin 0 -> 69383 bytes
58 .../sof-mtl-rt1019-rt5682.tplg | Bin 0 -> 59163 bytes
59 .../sof-mtl-rt1318-l12-rt714-l0.tplg | Bin 0 -> 36126 bytes
60 .../sof-mtl-rt5650-dts-google-aec.tplg | Bin 0 -> 86507 bytes
61 .../sof-ipc4-tplg-v2.11/sof-mtl-rt5650-dts.tplg | Bin 0 -> 76087 bytes
62 sof-ipc4-tplg-v2.11/sof-mtl-rt5650.tplg | Bin 0 -> 73167 bytes
63 .../sof-ipc4-tplg-v2.11/sof-mtl-rt711-4ch.tplg | Bin 0 -> 51555 bytes
64 .../sof-mtl-rt711-l0-rt1316-l23-rt714-l1.tplg | Bin 0 -> 54150 bytes
65 .../sof-mtl-rt711-l0-rt1316-l3-2ch.tplg | Bin 0 -> 64611 bytes
66 .../sof-mtl-rt711-l0-rt1316-l3-4ch.tplg | Bin 0 -> 64611 bytes
67 .../sof-mtl-rt711-l0-rt1316-l3.tplg | Bin 0 -> 46474 bytes
68 .../sof-mtl-rt712-l0-2ch.tplg | Bin 0 -> 59755 bytes
69 .../sof-mtl-rt712-l0-4ch.tplg | Bin 0 -> 59755 bytes
70 .../sof-mtl-rt712-l0-rt1712-l3.tplg | Bin 0 -> 47378 bytes
71 .../sof-ipc4-tplg-v2.11/sof-mtl-rt712-l0.tplg | Bin 0 -> 41618 bytes
72 .../sof-mtl-rt712-vb-l0.tplg | Bin 0 -> 47378 bytes
73 .../sof-mtl-rt713-l0-rt1316-l12-rt1713-l3.tplg | Bin 0 -> 54150 bytes
74 .../sof-mtl-rt713-l0-rt1316-l12.tplg | Bin 0 -> 48390 bytes
75 .../sof-mtl-rt713-l0-rt1318-l1-rt1713-l3.tplg | Bin 0 -> 52234 bytes
76 .../sof-mtl-rt713-l0-rt1318-l12-rt1713-l3.tplg | Bin 0 -> 54150 bytes
77 .../sof-ipc4-tplg-v2.11/sof-mtl-rt722-l0.tplg | Bin 0 -> 47378 bytes
78 .../sof-mtl-sdw-cs42l42-l0-max98363-l2.tplg | Bin 0 -> 69743 bytes
79 sof-ipc4-tplg-v2.11/sof-ptl-rt722.tplg | Bin 0 -> 47378 bytes
80 .../sof-ipc4-tplg-v2.11/sof-rpl-cs42l43-l0.tplg | Bin 0 -> 47378 bytes
81 .../sof-tgl-cs42l43-l3-cs35l56-l01.tplg | Bin 0 -> 48766 bytes
82 .../sof-tgl-rt711-rt1308-4ch.tplg | Bin 0 -> 59755 bytes
83 .../sof-tgl-rt711-rt1308-rt715.tplg | Bin 0 -> 48766 bytes
84 .../sof-tgl-rt711-rt1316-rt714.tplg | Bin 0 -> 54150 bytes
85 sof-ipc4-tplg-v2.11/sof-tgl-rt712.tplg | Bin 0 -> 47378 bytes
86 .../sof-tgl-rt715-rt711-rt1308-mono.tplg | Bin 0 -> 47378 bytes
87 73 files changed, 0 insertions(+), 0 deletions(-)
88 create mode 100644 sof-ipc4-tplg-v2.11/sof-adl-cs42l43-l0-cs35l56-l23.tplg
89 create mode 100644 sof-ipc4-tplg-v2.11/sof-adl-rt711-4ch.tplg
90 create mode 100644 sof-ipc4-tplg-v2.11/sof-adl-rt711-l0-rt1308-l12-rt715-l3.tplg
91 create mode 100644 sof-ipc4-tplg-v2.11/sof-adl-rt711-l0-rt1316-l12-rt714-l3.tplg
92 create mode 100644 sof-ipc4-tplg-v2.11/sof-adl-rt711-l0-rt1316-l13-rt714-l2.tplg
93 create mode 100644 sof-ipc4-tplg-v2.11/sof-arl-cs42l43-l0-cs35l56-l2.tplg
94 create mode 100644 sof-ipc4-tplg-v2.11/sof-arl-cs42l43-l0-cs35l56-l23.tplg
95 create mode 100644 sof-ipc4-tplg-v2.11/sof-arl-cs42l43-l0.tplg
96 create mode 100644 sof-ipc4-tplg-v2.11/sof-arl-cs42l43-l2-cs35l56-l3.tplg
97 create mode 100644 sof-ipc4-tplg-v2.11/sof-arl-cs42l43-l2.tplg
98 create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-2ch.tplg
99 create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-4ch.tplg
100 create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-ace1-2ch.tplg
101 create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-ace1-4ch.tplg
102 create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-ace1-idisp-2ch.tplg
103 create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-ace1-idisp-4ch.tplg
104 create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-cavs25-2ch.tplg
105 create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-cavs25-4ch.tplg
106 create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-cavs25-idisp-2ch.tplg
107 create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-cavs25-idisp-4ch.tplg
108 create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-idisp-2ch.tplg
109 create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-idisp-4ch.tplg
110 create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-idisp.tplg
111 create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic.tplg
112 create mode 100644 sof-ipc4-tplg-v2.11/sof-imx8mp-wm8960.tplg
113 create mode 100644 sof-ipc4-tplg-v2.11/sof-lnl-cs42l43-l0-cs35l56-l23.tplg
114 create mode 100644 sof-ipc4-tplg-v2.11/sof-lnl-cs42l43-l0-cs35l56-l3.tplg
115 create mode 100644 sof-ipc4-tplg-v2.11/sof-lnl-cs42l43-l0.tplg
116 create mode 100644 sof-ipc4-tplg-v2.11/sof-lnl-rt1318-l12-rt714-l0.tplg
117 create mode 100644 sof-ipc4-tplg-v2.11/sof-lnl-rt711-4ch.tplg
118 create mode 100644 sof-ipc4-tplg-v2.11/sof-lnl-rt711-l0-rt1316-l23-rt714-l1.tplg
119 create mode 100644 sof-ipc4-tplg-v2.11/sof-lnl-rt712-l2-rt1712-l3.tplg
120 create mode 100644 sof-ipc4-tplg-v2.11/sof-lnl-rt722-l0.tplg
121 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-cs42l43-l0-cs35l56-l12.tplg
122 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-cs42l43-l0-cs35l56-l23.tplg
123 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-cs42l43-l0.tplg
124 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-es83x6-ssp1-hdmi-ssp02.tplg
125 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-hdmi-ssp02.tplg
126 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-max98357a-rt5682-google-aec.tplg
127 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-max98357a-rt5682-ssp2-ssp0-2ch-pdm1-google-aec.tplg
128 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-max98357a-rt5682-ssp2-ssp0-2ch-pdm1.tplg
129 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-max98357a-rt5682-ssp2-ssp0-google-aec.tplg
130 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-max98357a-rt5682-ssp2-ssp0.tplg
131 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-max98357a-rt5682.tplg
132 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt1019-rt5682.tplg
133 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt1318-l12-rt714-l0.tplg
134 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt5650-dts-google-aec.tplg
135 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt5650-dts.tplg
136 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt5650.tplg
137 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt711-4ch.tplg
138 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt711-l0-rt1316-l23-rt714-l1.tplg
139 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt711-l0-rt1316-l3-2ch.tplg
140 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt711-l0-rt1316-l3-4ch.tplg
141 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt711-l0-rt1316-l3.tplg
142 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt712-l0-2ch.tplg
143 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt712-l0-4ch.tplg
144 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt712-l0-rt1712-l3.tplg
145 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt712-l0.tplg
146 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt712-vb-l0.tplg
147 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt713-l0-rt1316-l12-rt1713-l3.tplg
148 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt713-l0-rt1316-l12.tplg
149 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt713-l0-rt1318-l1-rt1713-l3.tplg
150 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt713-l0-rt1318-l12-rt1713-l3.tplg
151 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt722-l0.tplg
152 create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-sdw-cs42l42-l0-max98363-l2.tplg
153 create mode 100644 sof-ipc4-tplg-v2.11/sof-ptl-rt722.tplg
154 create mode 100644 sof-ipc4-tplg-v2.11/sof-rpl-cs42l43-l0.tplg
155 create mode 100644 sof-ipc4-tplg-v2.11/sof-tgl-cs42l43-l3-cs35l56-l01.tplg
156 create mode 100644 sof-ipc4-tplg-v2.11/sof-tgl-rt711-rt1308-4ch.tplg
157 create mode 100644 sof-ipc4-tplg-v2.11/sof-tgl-rt711-rt1308-rt715.tplg
158 create mode 100644 sof-ipc4-tplg-v2.11/sof-tgl-rt711-rt1316-rt714.tplg
159 create mode 100644 sof-ipc4-tplg-v2.11/sof-tgl-rt712.tplg
160 create mode 100644 sof-ipc4-tplg-v2.11/sof-tgl-rt715-rt711-rt1308-mono.tplg
161
162diff --git a/sof-ipc4-tplg-v2.11/sof-adl-cs42l43-l0-cs35l56-l23.tplg b/sof-ipc4-tplg-v2.11/sof-adl-cs42l43-l0-cs35l56-l23.tplg
163new file mode 100644
164index 0000000..bc15f09
165--- /dev/null
166+++ b/sof-ipc4-tplg-v2.11/sof-adl-cs42l43-l0-cs35l56-l23.tplg
167@@ -0,0 +1,120 @@
168+CoSA

Subscribers

People subscribed via source and target branches

to all changes: