Ubuntu
firmware-sof package

Merge ~mschiu77/ubuntu/+source/firmware-sof:ubuntu/noble-devel into ubuntu/+source/firmware-sof:ubuntu/noble-devel

  1. Git
  2. lp:~mschiu77/ubuntu/+source/firmware-sof
  3. ubuntu/noble-devel
  4. Merge into ubuntu/noble-devel
Proposed by Chris Chiu
Status: Needs review
Proposed branch: ~mschiu77/ubuntu/+source/firmware-sof:ubuntu/noble-devel
Merge into: ubuntu/+source/firmware-sof:ubuntu/noble-devel
Diff against target: 190 lines
Reviewer Review Type Date Requested Status
Lukas Märdian (community) Abstain
Vladimir Petko (community) Approve
You-Sheng Yang (community) Approve
Canonical Kernel Pending
Ubuntu Kernel Team Pending
git-ubuntu import Pending
Review via email: mp+474998@code.launchpad.net

Commit message

This requires following firmware blobs:
* linux-firmware
  - https://github.com/CirrusLogic/linux-firmware/commit/367fda8e56d7dda4c138438493e2bf6b9b92ce7b
* firmware-sof
  - sof-lnl-cs42l43-l0.tplg and the corresponding Intel firmware sof-lnl.ri

To post a comment you must log in.
Revision history for this message
You-Sheng Yang (vicamo) wrote :

Per comment in https://code.launchpad.net/~mschiu77/ubuntu/+source/firmware-sof/+git/firmware-sof/+merge/475977/comments/1288983, Needs Fixing for the same reason.

review: Needs Fixing
Reply
Revision history for this message
Chris Chiu (mschiu77) wrote :

Fix the patch to add the sof-ipc4-lib back per requested.

Reply
Revision history for this message
Chris Chiu (mschiu77) wrote :

Fix the `Origin` url per requested

Reply
Revision history for this message
You-Sheng Yang (vicamo) wrote :

LGTM.

review: Approve
Reply
Revision history for this message
Julian Andres Klode (juliank) wrote :

This isn't particularly easy to sponsor, as there's no easy way to check that the patch included is the same one as upstream, as this adds binaries, which are not particularly supported in patches, and the git patch format for binaries is different.

Hence I'd need to grab the upstream patch, apply it, record hashes, apply this patch, record hashes, and this seems very time intense, so I'll not review any of the firmware-sof patches in this patch pilot round, sorry.

Reply
Revision history for this message
Vladimir Petko (vpa1977) wrote :

Validated against upstream/plucky.

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading firmware-sof_2023.12.1-1ubuntu1.2.dsc: done.
  Uploading firmware-sof_2023.12.1-1ubuntu1.2.debian.tar.xz: done.
  Uploading firmware-sof_2023.12.1-1ubuntu1.2_source.buildinfo: done.
  Uploading firmware-sof_2023.12.1-1ubuntu1.2_source.changes: done.
Successfully uploaded packages.

review: Approve
Reply
Revision history for this message
Anthony Wong (anthonywong) wrote :

This MR has been merged to Noble and package has already been released.

Reply
Revision history for this message
Lukas Märdian (slyon) wrote :

Already sponsored, as stated in the comment before. Removing ~ubuntu-sponsors.

review: Abstain
Reply

Unmerged commits

b38ce37... by Chris Chiu

2023.12.1-1ubuntu1.2 (patches unapplied)

Imported using git-ubuntu import.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 0fdeab4..69660c8 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+firmware-sof (2023.12.1-1ubuntu1.2) noble; urgency=medium
7+
8+ * Missing CS35L56 sof firmware for Dell Bolan platform. (LP: #2077829)
9+ - Add 2.11 topology2 production binaries
10+ - Add SOF v2.11.1 signed Intel binaries for MTL/LNL/ARL
11+
12+ -- Chris Chiu <chris.chiu@canonical.com> Mon, 14 Oct 2024 15:50:54 +0800
13+
14 firmware-sof (2023.12.1-1ubuntu1.1) noble; urgency=medium
15
16 * Soundwire support for CS42L43 and CS35L56 on Intel MTL. (LP: #2069760)
17diff --git a/debian/patches/0003-Add-2.11-topology2-production-binaries.patch b/debian/patches/0003-Add-2.11-topology2-production-binaries.patch
18new file mode 100644
19index 0000000..6b857f8
20--- /dev/null
21+++ b/debian/patches/0003-Add-2.11-topology2-production-binaries.patch
22@@ -0,0 +1,10719 @@
23+From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
24+Date: Mon, 23 Sep 2024 14:12:38 +0300
25+Subject: [PATCH] Add 2.11 topology2 production binaries
26+
27+Add binaries for all production topology2 binaries.
28+
29+Generated with Intel SOF build, identification "Build #5357".
30+
31+Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
32+Origin: backport, https://github.com/thesofproject/sof-bin/commit/72d761ef5503e0779f3b57d180dcd2383e75efa4.patch
33+Bug-Ubuntu: https://bugs.launchpad.net/bugs/2077829
34+Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
35+---
36+ .../sof-adl-cs42l43-l0-cs35l56-l23.tplg | Bin 0 -> 48766 bytes
37+ .../sof-ipc4-tplg-v2.11/sof-adl-rt711-4ch.tplg | Bin 0 -> 51555 bytes
38+ .../sof-adl-rt711-l0-rt1308-l12-rt715-l3.tplg | Bin 0 -> 48766 bytes
39+ .../sof-adl-rt711-l0-rt1316-l12-rt714-l3.tplg | Bin 0 -> 54150 bytes
40+ .../sof-adl-rt711-l0-rt1316-l13-rt714-l2.tplg | Bin 0 -> 54150 bytes
41+ .../sof-arl-cs42l43-l0-cs35l56-l2.tplg | Bin 0 -> 47378 bytes
42+ .../sof-arl-cs42l43-l0-cs35l56-l23.tplg | Bin 0 -> 48766 bytes
43+ .../sof-ipc4-tplg-v2.11/sof-arl-cs42l43-l0.tplg | Bin 0 -> 47378 bytes
44+ .../sof-arl-cs42l43-l2-cs35l56-l3.tplg | Bin 0 -> 47378 bytes
45+ .../sof-ipc4-tplg-v2.11/sof-arl-cs42l43-l2.tplg | Bin 0 -> 47378 bytes
46+ .../sof-hda-generic-2ch.tplg | Bin 0 -> 58374 bytes
47+ .../sof-hda-generic-4ch.tplg | Bin 0 -> 57758 bytes
48+ .../sof-hda-generic-ace1-2ch.tplg | Bin 0 -> 64595 bytes
49+ .../sof-hda-generic-ace1-4ch.tplg | Bin 0 -> 63979 bytes
50+ .../sof-hda-generic-ace1-idisp-2ch.tplg | Bin 0 -> 36267 bytes
51+ .../sof-hda-generic-ace1-idisp-4ch.tplg | Bin 0 -> 36267 bytes
52+ .../sof-hda-generic-cavs25-2ch.tplg | Bin 0 -> 64595 bytes
53+ .../sof-hda-generic-cavs25-4ch.tplg | Bin 0 -> 63979 bytes
54+ .../sof-hda-generic-cavs25-idisp-2ch.tplg | Bin 0 -> 36267 bytes
55+ .../sof-hda-generic-cavs25-idisp-4ch.tplg | Bin 0 -> 36267 bytes
56+ .../sof-hda-generic-idisp-2ch.tplg | Bin 0 -> 30046 bytes
57+ .../sof-hda-generic-idisp-4ch.tplg | Bin 0 -> 30046 bytes
58+ .../sof-hda-generic-idisp.tplg | Bin 0 -> 18130 bytes
59+ .../sof-ipc4-tplg-v2.11/sof-hda-generic.tplg | Bin 0 -> 45774 bytes
60+ .../sof-ipc4-tplg-v2.11/sof-imx8mp-wm8960.tplg | Bin 0 -> 4158 bytes
61+ .../sof-lnl-cs42l43-l0-cs35l56-l23.tplg | Bin 0 -> 48766 bytes
62+ .../sof-lnl-cs42l43-l0-cs35l56-l3.tplg | Bin 0 -> 47378 bytes
63+ .../sof-ipc4-tplg-v2.11/sof-lnl-cs42l43-l0.tplg | Bin 0 -> 47378 bytes
64+ .../sof-lnl-rt1318-l12-rt714-l0.tplg | Bin 0 -> 36126 bytes
65+ .../sof-ipc4-tplg-v2.11/sof-lnl-rt711-4ch.tplg | Bin 0 -> 51555 bytes
66+ .../sof-lnl-rt711-l0-rt1316-l23-rt714-l1.tplg | Bin 0 -> 54150 bytes
67+ .../sof-lnl-rt712-l2-rt1712-l3.tplg | Bin 0 -> 47378 bytes
68+ .../sof-ipc4-tplg-v2.11/sof-lnl-rt722-l0.tplg | Bin 0 -> 47378 bytes
69+ .../sof-mtl-cs42l43-l0-cs35l56-l12.tplg | Bin 0 -> 54150 bytes
70+ .../sof-mtl-cs42l43-l0-cs35l56-l23.tplg | Bin 0 -> 48766 bytes
71+ .../sof-ipc4-tplg-v2.11/sof-mtl-cs42l43-l0.tplg | Bin 0 -> 47378 bytes
72+ .../sof-mtl-es83x6-ssp1-hdmi-ssp02.tplg | Bin 0 -> 36881 bytes
73+ .../sof-ipc4-tplg-v2.11/sof-mtl-hdmi-ssp02.tplg | Bin 0 -> 26325 bytes
74+ .../sof-mtl-max98357a-rt5682-google-aec.tplg | Bin 0 -> 79803 bytes
75+ ...7a-rt5682-ssp2-ssp0-2ch-pdm1-google-aec.tplg | Bin 0 -> 83587 bytes
76+ ...mtl-max98357a-rt5682-ssp2-ssp0-2ch-pdm1.tplg | Bin 0 -> 73167 bytes
77+ ...l-max98357a-rt5682-ssp2-ssp0-google-aec.tplg | Bin 0 -> 83587 bytes
78+ .../sof-mtl-max98357a-rt5682-ssp2-ssp0.tplg | Bin 0 -> 73167 bytes
79+ .../sof-mtl-max98357a-rt5682.tplg | Bin 0 -> 69383 bytes
80+ .../sof-mtl-rt1019-rt5682.tplg | Bin 0 -> 59163 bytes
81+ .../sof-mtl-rt1318-l12-rt714-l0.tplg | Bin 0 -> 36126 bytes
82+ .../sof-mtl-rt5650-dts-google-aec.tplg | Bin 0 -> 86507 bytes
83+ .../sof-ipc4-tplg-v2.11/sof-mtl-rt5650-dts.tplg | Bin 0 -> 76087 bytes
84+ sof-ipc4-tplg-v2.11/sof-mtl-rt5650.tplg | Bin 0 -> 73167 bytes
85+ .../sof-ipc4-tplg-v2.11/sof-mtl-rt711-4ch.tplg | Bin 0 -> 51555 bytes
86+ .../sof-mtl-rt711-l0-rt1316-l23-rt714-l1.tplg | Bin 0 -> 54150 bytes
87+ .../sof-mtl-rt711-l0-rt1316-l3-2ch.tplg | Bin 0 -> 64611 bytes
88+ .../sof-mtl-rt711-l0-rt1316-l3-4ch.tplg | Bin 0 -> 64611 bytes
89+ .../sof-mtl-rt711-l0-rt1316-l3.tplg | Bin 0 -> 46474 bytes
90+ .../sof-mtl-rt712-l0-2ch.tplg | Bin 0 -> 59755 bytes
91+ .../sof-mtl-rt712-l0-4ch.tplg | Bin 0 -> 59755 bytes
92+ .../sof-mtl-rt712-l0-rt1712-l3.tplg | Bin 0 -> 47378 bytes
93+ .../sof-ipc4-tplg-v2.11/sof-mtl-rt712-l0.tplg | Bin 0 -> 41618 bytes
94+ .../sof-mtl-rt712-vb-l0.tplg | Bin 0 -> 47378 bytes
95+ .../sof-mtl-rt713-l0-rt1316-l12-rt1713-l3.tplg | Bin 0 -> 54150 bytes
96+ .../sof-mtl-rt713-l0-rt1316-l12.tplg | Bin 0 -> 48390 bytes
97+ .../sof-mtl-rt713-l0-rt1318-l1-rt1713-l3.tplg | Bin 0 -> 52234 bytes
98+ .../sof-mtl-rt713-l0-rt1318-l12-rt1713-l3.tplg | Bin 0 -> 54150 bytes
99+ .../sof-ipc4-tplg-v2.11/sof-mtl-rt722-l0.tplg | Bin 0 -> 47378 bytes
100+ .../sof-mtl-sdw-cs42l42-l0-max98363-l2.tplg | Bin 0 -> 69743 bytes
101+ sof-ipc4-tplg-v2.11/sof-ptl-rt722.tplg | Bin 0 -> 47378 bytes
102+ .../sof-ipc4-tplg-v2.11/sof-rpl-cs42l43-l0.tplg | Bin 0 -> 47378 bytes
103+ .../sof-tgl-cs42l43-l3-cs35l56-l01.tplg | Bin 0 -> 48766 bytes
104+ .../sof-tgl-rt711-rt1308-4ch.tplg | Bin 0 -> 59755 bytes
105+ .../sof-tgl-rt711-rt1308-rt715.tplg | Bin 0 -> 48766 bytes
106+ .../sof-tgl-rt711-rt1316-rt714.tplg | Bin 0 -> 54150 bytes
107+ sof-ipc4-tplg-v2.11/sof-tgl-rt712.tplg | Bin 0 -> 47378 bytes
108+ .../sof-tgl-rt715-rt711-rt1308-mono.tplg | Bin 0 -> 47378 bytes
109+ 73 files changed, 0 insertions(+), 0 deletions(-)
110+ create mode 100644 sof-ipc4-tplg-v2.11/sof-adl-cs42l43-l0-cs35l56-l23.tplg
111+ create mode 100644 sof-ipc4-tplg-v2.11/sof-adl-rt711-4ch.tplg
112+ create mode 100644 sof-ipc4-tplg-v2.11/sof-adl-rt711-l0-rt1308-l12-rt715-l3.tplg
113+ create mode 100644 sof-ipc4-tplg-v2.11/sof-adl-rt711-l0-rt1316-l12-rt714-l3.tplg
114+ create mode 100644 sof-ipc4-tplg-v2.11/sof-adl-rt711-l0-rt1316-l13-rt714-l2.tplg
115+ create mode 100644 sof-ipc4-tplg-v2.11/sof-arl-cs42l43-l0-cs35l56-l2.tplg
116+ create mode 100644 sof-ipc4-tplg-v2.11/sof-arl-cs42l43-l0-cs35l56-l23.tplg
117+ create mode 100644 sof-ipc4-tplg-v2.11/sof-arl-cs42l43-l0.tplg
118+ create mode 100644 sof-ipc4-tplg-v2.11/sof-arl-cs42l43-l2-cs35l56-l3.tplg
119+ create mode 100644 sof-ipc4-tplg-v2.11/sof-arl-cs42l43-l2.tplg
120+ create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-2ch.tplg
121+ create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-4ch.tplg
122+ create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-ace1-2ch.tplg
123+ create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-ace1-4ch.tplg
124+ create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-ace1-idisp-2ch.tplg
125+ create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-ace1-idisp-4ch.tplg
126+ create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-cavs25-2ch.tplg
127+ create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-cavs25-4ch.tplg
128+ create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-cavs25-idisp-2ch.tplg
129+ create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-cavs25-idisp-4ch.tplg
130+ create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-idisp-2ch.tplg
131+ create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-idisp-4ch.tplg
132+ create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic-idisp.tplg
133+ create mode 100644 sof-ipc4-tplg-v2.11/sof-hda-generic.tplg
134+ create mode 100644 sof-ipc4-tplg-v2.11/sof-imx8mp-wm8960.tplg
135+ create mode 100644 sof-ipc4-tplg-v2.11/sof-lnl-cs42l43-l0-cs35l56-l23.tplg
136+ create mode 100644 sof-ipc4-tplg-v2.11/sof-lnl-cs42l43-l0-cs35l56-l3.tplg
137+ create mode 100644 sof-ipc4-tplg-v2.11/sof-lnl-cs42l43-l0.tplg
138+ create mode 100644 sof-ipc4-tplg-v2.11/sof-lnl-rt1318-l12-rt714-l0.tplg
139+ create mode 100644 sof-ipc4-tplg-v2.11/sof-lnl-rt711-4ch.tplg
140+ create mode 100644 sof-ipc4-tplg-v2.11/sof-lnl-rt711-l0-rt1316-l23-rt714-l1.tplg
141+ create mode 100644 sof-ipc4-tplg-v2.11/sof-lnl-rt712-l2-rt1712-l3.tplg
142+ create mode 100644 sof-ipc4-tplg-v2.11/sof-lnl-rt722-l0.tplg
143+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-cs42l43-l0-cs35l56-l12.tplg
144+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-cs42l43-l0-cs35l56-l23.tplg
145+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-cs42l43-l0.tplg
146+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-es83x6-ssp1-hdmi-ssp02.tplg
147+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-hdmi-ssp02.tplg
148+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-max98357a-rt5682-google-aec.tplg
149+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-max98357a-rt5682-ssp2-ssp0-2ch-pdm1-google-aec.tplg
150+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-max98357a-rt5682-ssp2-ssp0-2ch-pdm1.tplg
151+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-max98357a-rt5682-ssp2-ssp0-google-aec.tplg
152+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-max98357a-rt5682-ssp2-ssp0.tplg
153+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-max98357a-rt5682.tplg
154+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt1019-rt5682.tplg
155+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt1318-l12-rt714-l0.tplg
156+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt5650-dts-google-aec.tplg
157+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt5650-dts.tplg
158+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt5650.tplg
159+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt711-4ch.tplg
160+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt711-l0-rt1316-l23-rt714-l1.tplg
161+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt711-l0-rt1316-l3-2ch.tplg
162+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt711-l0-rt1316-l3-4ch.tplg
163+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt711-l0-rt1316-l3.tplg
164+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt712-l0-2ch.tplg
165+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt712-l0-4ch.tplg
166+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt712-l0-rt1712-l3.tplg
167+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt712-l0.tplg
168+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt712-vb-l0.tplg
169+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt713-l0-rt1316-l12-rt1713-l3.tplg
170+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt713-l0-rt1316-l12.tplg
171+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt713-l0-rt1318-l1-rt1713-l3.tplg
172+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt713-l0-rt1318-l12-rt1713-l3.tplg
173+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-rt722-l0.tplg
174+ create mode 100644 sof-ipc4-tplg-v2.11/sof-mtl-sdw-cs42l42-l0-max98363-l2.tplg
175+ create mode 100644 sof-ipc4-tplg-v2.11/sof-ptl-rt722.tplg
176+ create mode 100644 sof-ipc4-tplg-v2.11/sof-rpl-cs42l43-l0.tplg
177+ create mode 100644 sof-ipc4-tplg-v2.11/sof-tgl-cs42l43-l3-cs35l56-l01.tplg
178+ create mode 100644 sof-ipc4-tplg-v2.11/sof-tgl-rt711-rt1308-4ch.tplg
179+ create mode 100644 sof-ipc4-tplg-v2.11/sof-tgl-rt711-rt1308-rt715.tplg
180+ create mode 100644 sof-ipc4-tplg-v2.11/sof-tgl-rt711-rt1316-rt714.tplg
181+ create mode 100644 sof-ipc4-tplg-v2.11/sof-tgl-rt712.tplg
182+ create mode 100644 sof-ipc4-tplg-v2.11/sof-tgl-rt715-rt711-rt1308-mono.tplg
183+
184+diff --git a/sof-ipc4-tplg-v2.11/sof-adl-cs42l43-l0-cs35l56-l23.tplg b/sof-ipc4-tplg-v2.11/sof-adl-cs42l43-l0-cs35l56-l23.tplg
185+new file mode 100644
186+index 0000000..bc15f09
187+--- /dev/null
188++++ b/sof-ipc4-tplg-v2.11/sof-adl-cs42l43-l0-cs35l56-l23.tplg
189+@@ -0,0 +1,120 @@
190++CoSA

Subscribers

People subscribed via source and target branches

to all changes: