Merge lp:~mriedesel/poppler-python/form-field-names into lp:~kiyoka/poppler-python/no-pygtk

Proposed by Mark Riedesel
Status: Approved
Approved by: Kevin Tardif
Approved revision: 88
Proposed branch: lp:~mriedesel/poppler-python/form-field-names
Merge into: lp:~kiyoka/poppler-python/no-pygtk
Diff against target: 28 lines (+18/-0)
1 file modified
poppler.defs (+18/-0)
To merge this branch: bzr merge lp:~mriedesel/poppler-python/form-field-names
Reviewer Review Type Date Requested Status
Kevin Tardif Approve
Review via email:
To post a comment you must log in.
Revision history for this message
Mark Riedesel (mriedesel) wrote :

Added bindings for the following form field access methods:


I submitted this patch to trunk as well but it appears they haven't accepted any patches for a few years now. I also really appreciate your work in removing the pygtk dependency.



Revision history for this message
Kevin Tardif (kiyoka) wrote :

Thanks for the changes, and glad you found the fork was helpful. And ya, it seems trunk is dead; I sent a merge request back when I forked it as well, but judging by the fact that it hasn't merged any fixes for a long time I wasn't surprised to not get a reply.

Revision history for this message
Kevin Tardif (kiyoka) :
review: Approve

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'poppler.defs'
2--- poppler.defs 2012-10-29 05:22:38 +0000
3+++ poppler.defs 2013-10-07 21:37:03 +0000
4@@ -1450,6 +1450,24 @@
5 )
6 )
8+(define-method get_partial_name
9+ (of-object "PopplerFormField")
10+ (c-name "poppler_form_field_get_partial_name")
11+ (return-type "gchar*")
14+(define-method get_mapping_name
15+ (of-object "PopplerFormField")
16+ (c-name "poppler_form_field_get_mapping_name")
17+ (return-type "gchar*")
20+(define-method get_name
21+ (of-object "PopplerFormField")
22+ (c-name "poppler_form_field_get_name")
23+ (return-type "gchar*")
26 (define-method text_get_max_len
27 (of-object "PopplerFormField")
28 (c-name "poppler_form_field_text_get_max_len")


People subscribed via source and target branches

to all changes: