CONFIG_HP_WATCHDOG is used in module hpwdt. A software monitoring watchdog
and NMI handling driver. This driver will detect lockups and provide
a stack trace. This is a driver that will only load on an HP ProLiant
system with a minimum of iLO2 support. This option allow it to build
on arm64.
(backported from commit 891862d5ba11da739ac796221ff64e4ccf5a275f)
Signed-off-by: Michael Reed <email address hidden>
[Michael Reed - Added arm64 option to the config file for CONFIG_HP_WATCHDOG]
As that commit describes, on early Sapphire Rapids Xeon platforms the C1 and
C1E states were mutually exclusive, so that users could only have either C1 and
C6, or C1E and C6.
However, Intel firmware engineers managed to remove this limitation and make C1
and C1E to be completely independent, just like on previous Xeon platforms.
Therefore, this patch:
* Removes commentary describing the old, and now non-existing SPR C1E
limitation.
* Marks SPR C1E as available by default.
* Removes the 'preferred_cstates' parameter handling for SPR. Both C1 and
C1E will be available regardless of 'preferred_cstates' value.
We expect that all SPR systems are shipping with new firmware, which includes
the C1/C1E improvement.
Cc: v5.18+ <email address hidden> # v5.18+
Signed-off-by: Artem Bityutskiy <email address hidden>
Signed-off-by: Rafael J. Wysocki <email address hidden>
(backported from commit 1548fac47a114b42063def551eb152a536ed9697)
[jsalisbury: Resolved context diffs. adl structs do not exist in Jammy]
Signed-off-by: Joseph Salisbury <email address hidden>
Acked-by: Tim Gardner <email address hidden>
Acked-by: Stefan Bader <email address hidden>
Signed-off-by: Stefan Bader <email address hidden>
533fa60...
by
Artem Bityutskiy <email address hidden>
The Sapphire Rapids (SPR) C6 optimization was added to the end of the
'spr_idle_state_table_update()' function. However, the function has a
'return' which may happen before the optimization has a chance to run.
And this may prevent the optimization from happening.
This is an unlikely scenario, but possible if user boots with, say,
the 'intel_idle.preferred_cstates=6' kernel boot option.
This patch fixes the issue by eliminating the problematic 'return'
statement.
Fixes: 3a9cf77b60dc ("intel_idle: add core C6 optimization for SPR")
Suggested-by: Jan Beulich <email address hidden>
Reported-by: Jan Beulich <email address hidden>
Signed-off-by: Artem Bityutskiy <email address hidden>
[ rjw: Minor changelog edits ]
Signed-off-by: Rafael J. Wysocki <email address hidden>
(cherry picked from commit 7eac3bd38d18cd3317756649921b8264ddfee692)
Signed-off-by: Joseph Salisbury <email address hidden>
Acked-by: Tim Gardner <email address hidden>
Acked-by: Stefan Bader <email address hidden>
Signed-off-by: Stefan Bader <email address hidden>
bad3aaf...
by
Artem Bityutskiy <email address hidden>
intel_idle: Fix the 'preferred_cstates' module parameter
When user boots kernel up with the 'intel_idle.preferred_cstates=4' option,
we enable C1E and disable C1 states on Sapphire Rapids Xeon (SPR). In order
for C1E to work on SPR, we have to enable the C1E promotion bit on all
CPUs. However, we enable it only on one CPU.
Fix description.
The 'intel_idle' driver already has the infrastructure for disabling C1E
promotion on every CPU. This patch uses the same infrastructure for
enabling C1E promotion on every CPU. It changes the boolean
'disable_promotion_to_c1e' variable to a tri-state 'c1e_promotion'
variable.
Tested on a 2-socket SPR system. I verified the following combinations:
* C1E promotion enabled and disabled in BIOS.
* Booted with and without the 'intel_idle.preferred_cstates=4' kernel
argument.
In all 4 cases C1E promotion was correctly set on all CPUs.
Also tested on an old Broadwell system, just to make sure it does not cause
a regression. C1E promotion was correctly disabled on that system, both C1
and C1E were exposed (as expected).
Fixes: da0e58c038e6 ("intel_idle: add 'preferred_cstates' module argument")
Reported-by: Jan Beulich <email address hidden>
Signed-off-by: Artem Bityutskiy <email address hidden>
[ rjw: Minor changelog edits ]
Signed-off-by: Rafael J. Wysocki <email address hidden>
(cherry picked from commit 39c184a6a9a7a99950b321d55fe713175cf1d404)
Signed-off-by: Joseph Salisbury <email address hidden>
Acked-by: Tim Gardner <email address hidden>
Acked-by: Stefan Bader <email address hidden>
Signed-off-by: Stefan Bader <email address hidden>
b072fe1...
by
"Rafael J. Wysocki" <email address hidden>
cpuidle: intel_idle: Drop redundant backslash at line end