Merge lp:~mrasmus/unity/fix-686182 into lp:unity
Proposed by
Matthew Rasmus
Status: | Merged |
---|---|
Merged at revision: | 699 |
Proposed branch: | lp:~mrasmus/unity/fix-686182 |
Merge into: | lp:unity |
Diff against target: |
50 lines (+18/-3) 2 files modified
src/BamfLauncherIcon.cpp (+7/-1) src/Launcher.cpp (+11/-2) |
To merge this branch: | bzr merge lp:~mrasmus/unity/fix-686182 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jason Smith (community) | Approve | ||
Alex Launi (community) | Needs Fixing | ||
Review via email: mp+43141@code.launchpad.net |
To post a comment you must log in.
A few things.
This breaks the flashing background animation while an application is loading. The background just immediately turns colored.
If an application crashes on startup, it gets marked as running. Granted that we should fix apps so they don't crash on startup, they still do. A good way to test this when you're fixing your patch is to edit /usr/bin/gwibber and add raise RuntimeException before gtk.Main() at the end of the file.
My advice would be to use LAUNCHER_ ICON_QUICK_ STARTING and do something similar.
Style guidelines say to put a space between method calls and parameters. ICON_QUIRK_ RUNNING) LAUNCHER_ ICON_QUIRK_ RUNNING)
!GetQuirk (LAUNCHER_
not
!GetQuirk(
And before we can merge we need you to sign the Canonical contributers agreement: http:// www.canonical. com/contributor s.