Merge lp:~mpt/ubuntu-ui-toolkit/1542099-window-title into lp:ubuntu-ui-toolkit

[Matthew Paul Thomas]

Warning: I have not tested this change at all.

It removes code that appears to set the window title to be the same as the header title.

Setting the window title to be the same as the header title is undesirable for two reasons: it’s highly visible redundancy, and whenever the app has multiple screens it means the window title often isn’t the name of the app.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1281
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/2280/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-vivid-amd64-ci/103
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-vivid-armhf-ci/104
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-vivid-armhf-ci/104/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-toolkit-ci/2280/rebuild

review: Approve (continuous-integration)

[Zsombor Egri (zsombi)]

The solution has been added as without this the task switcher doesn't show the name of the application. We need another solution for that but until that we must keep this solution.

review: Disapprove

Unmerged revisions

1281. By Matthew Paul Thomas on 2016-02-22

Stops changing an app's window title when the header changes.

=== modified file 'src/Ubuntu/Components/1.3/MainView.qml'
--- src/Ubuntu/Components/1.3/MainView.qml	2015-10-13 13:37:43 +0000
+++ src/Ubuntu/Components/1.3/MainView.qml	2016-02-22 11:03:04 +0000
@@ -186,17 +186,6 @@
             // 'window' is defined by QML between startup and showing on the screen.
             // There is no signal for when it becomes available and re-declaring it is not safe.
             property bool windowActive: typeof window != 'undefined'
-            onWindowActiveChanged: {
-                window.title = headerItem.title
-            }
-
-            Connections {
-                target: headerItem
-                onTitleChanged: {
-                    if (headerItem.windowActive)
-                        window.title = headerItem.title
-                }
-            }
         }
 
         Connections {