Merge lp:~mpt/software-center/text-tweaks into lp:software-center

Proposed by Matthew Paul Thomas
Status: Merged
Merged at revision: 2207
Proposed branch: lp:~mpt/software-center/text-tweaks
Merge into: lp:software-center
Diff against target: 77 lines (+12/-12)
2 files modified
softwarecenter/ui/gtk/widgets/reviews.py (+2/-2)
softwarecenter/ui/gtk3/widgets/reviews.py (+10/-10)
To merge this branch: bzr merge lp:~mpt/software-center/text-tweaks
Reviewer Review Type Date Requested Status
Michael Vogt Pending
Review via email: mp+72901@code.launchpad.net

Description of the change

Various tweaks to text and fonts:
- Moves the Version info to the top of "Details", and puts the package name first.
- Downplays the text explaining why you can't review something.
- Downplays the reviewer names and dates.
- Explains how to fix the problem that you can't see more reviews.
- Moves the price to be in line with the rest of the text in tiles (bug 833707).

To post a comment you must log in.
lp:~mpt/software-center/text-tweaks updated
2212. By Matthew Paul Thomas

Moves the price below the other tile text (bug 833707).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/ui/gtk/widgets/reviews.py'
2--- softwarecenter/ui/gtk/widgets/reviews.py 2011-08-17 11:44:31 +0000
3+++ softwarecenter/ui/gtk/widgets/reviews.py 2011-08-25 14:00:02 +0000
4@@ -788,7 +788,7 @@
5 return
6
7 def _install_to_review(self):
8- s = '<small><b>%s</b></small>' % _("You need to install this app before you can review it")
9+ s = '<small>%s</small>' % _("You need to install this before you can review it")
10 self.install_first_label = gtk.Label(s)
11 self.install_first_label.set_use_markup(True)
12 self.header.pack_end(self.install_first_label, False, padding=2)
13@@ -1469,7 +1469,7 @@
14 # TRANSLATORS: displayed if there are no reviews for the app yet
15 # and the user does not have it installed
16 title = _("This app has not been reviewed yet")
17- msg = _('You need to install this app before you can review it')
18+ msg = _('You need to install this before you can review it')
19 EmbeddedMessage.__init__(self, title, msg)
20
21
22
23=== modified file 'softwarecenter/ui/gtk3/widgets/reviews.py'
24--- softwarecenter/ui/gtk3/widgets/reviews.py 2011-08-25 13:13:10 +0000
25+++ softwarecenter/ui/gtk3/widgets/reviews.py 2011-08-25 14:00:02 +0000
26@@ -153,7 +153,7 @@
27 return
28
29 def _install_to_review(self):
30- s = '<small><b>%s</b></small>' % _("You need to install this app before you can review it")
31+ s = '<small>%s</small>' % _("You need to install this before you can review it")
32 self.install_first_label = Gtk.Label(label=s)
33 self.install_first_label.set_use_markup(True)
34 self.install_first_label.set_alignment(1.0, 0.5)
35@@ -170,8 +170,8 @@
36 return False
37
38 def _add_no_network_connection_msg(self):
39- title = _('No Network Connection')
40- msg = _('Only saved reviews can be displayed')
41+ title = _('No network connection')
42+ msg = _('Connect to the Internet to see more reviews.')
43 m = EmbeddedMessage(title, msg, 'network-offline')
44 self.vbox.pack_start(m, True, True, 0)
45 return m
46@@ -674,18 +674,18 @@
47 correct_name = displayname or person
48
49 if person == self.logged_in_person:
50- m = '<small><b>%s (%s)</b></small>\n<span font_size="%s">%s</span>' % (
51+ m = '<span color="%s">%s (%s), %s</span>' % (
52+ self._subtle,
53 GObject.markup_escape_text(correct_name),
54 # TRANSLATORS: displayed in a review after the persons name,
55- # e.g. "Wonderful text based app" mvo (that's you) 2011-02-11"
56- _("that's you"),
57- 8 * Pango.SCALE,
58+ # e.g. "Jane Smith (that's you), 2011-02-11"
59+ _(u"that\u2019s you"),
60 GObject.markup_escape_text(nice_date))
61 else:
62 try:
63- m = '<small><b>%s</b></small>\n<span font_size="%s">%s</span>' % (
64+ m = '<span color="%s">%s, %s</span>' % (
65+ self._subtle,
66 GObject.markup_escape_text(correct_name.encode("utf-8")),
67- 8 * Pango.SCALE,
68 GObject.markup_escape_text(nice_date))
69 except Exception:
70 LOG.exception("_who_when_markup failed")
71@@ -739,7 +739,7 @@
72 # TRANSLATORS: displayed if there are no reviews for the app yet
73 # and the user does not have it installed
74 title = _("This app has not been reviewed yet")
75- msg = _('You need to install this app before you can review it')
76+ msg = _('You need to install this before you can review it')
77 EmbeddedMessage.__init__(self, title, msg)
78
79