Merge lp:~mpt/reminders-app/1551780-setup into lp:reminders-app

Proposed by Matthew Paul Thomas
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 🦄
Approved revision: 543
Merged at revision: 549
Proposed branch: lp:~mpt/reminders-app/1551780-setup
Merge into: lp:reminders-app
Diff against target: 44 lines (+5/-7)
1 file modified
src/app/qml/Reminders.qml (+5/-7)
To merge this branch: bzr merge lp:~mpt/reminders-app/1551780-setup
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 🦄 (community) Approve
Michael Zanetti (community) Approve
Review via email: mp+287658@code.launchpad.net

Commit message

update some strings

Description of the change

Shortens and copyedits text in the Evernote sync dialog, fixing bug 1551780.

Also changes the dialog buttons:
* “No” to “Not Now”, since you can change your mind later
* red to grey, since a single dialog shouldn't have both green and red buttons
* “Yes” to “Set Up…”, since you have to do something more to set up the account.

To post a comment you must log in.
Revision history for this message
Michael Zanetti (mzanetti) wrote :

thanks!

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~mpt/reminders-app/1551780-setup/+merge/287658/+edit-commit-message

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/295/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/5646/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/306/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/5686/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) :
review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/307/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/5687/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/Reminders.qml'
2--- src/app/qml/Reminders.qml 2015-11-20 11:11:49 +0000
3+++ src/app/qml/Reminders.qml 2016-03-01 16:08:15 +0000
4@@ -227,7 +227,7 @@
5 switch (accounts.count) {
6 case 0:
7 PopupUtils.open(noAccountDialog, root);
8- print("No account available! Please setup an account in the system settings");
9+ print("No account available. Please set up an account in System Settings.");
10 break;
11 case 1:
12 print("Connecting to account", accounts.get(0, "displayName"), "as there is only one account available");
13@@ -711,10 +711,9 @@
14 Dialog {
15 id: noAccount
16 objectName: "noAccountDialog"
17- title: i18n.tr("Setup Evernote connection?")
18+ title: i18n.tr("Sync with Evernote")
19 text: i18n.tr("Notes can be stored on this device, or optionally synced with Evernote.") + " "
20- + i18n.tr("In order to synchronize notes with Evernote, an account at Evernote is required.") + " "
21- + i18n.tr("Do you want to setup an account now?")
22+ + i18n.tr("To sync with Evernote, you need an Evernote account.")
23
24 Connections {
25 target: accounts
26@@ -729,8 +728,7 @@
27 RowLayout {
28 Button {
29 objectName: "openAccountButton"
30- text: i18n.tr("No")
31- color: UbuntuColors.red
32+ text: i18n.tr("Not Now")
33 onClicked: {
34 PopupUtils.close(noAccount)
35 accountService.startAuthentication("@local", null);
36@@ -739,7 +737,7 @@
37 }
38 Button {
39 objectName: "openAccountButton"
40- text: i18n.tr("Yes")
41+ text: i18n.tr("Set Up…")
42 color: UbuntuColors.green
43 onClicked: setup.exec()
44 Layout.fillWidth: true

Subscribers

People subscribed via source and target branches