Merge lp:~mpredotka/ubuntu-clock-app/fix-header-in-alarms into lp:ubuntu-clock-app

Proposed by Michal Predotka
Status: Merged
Approved by: Bartosz Kosiorek
Approved revision: 477
Merged at revision: 478
Proposed branch: lp:~mpredotka/ubuntu-clock-app/fix-header-in-alarms
Merge into: lp:ubuntu-clock-app
Diff against target: 26 lines (+1/-3)
1 file modified
app/alarm/AlarmPage.qml (+1/-3)
To merge this branch: bzr merge lp:~mpredotka/ubuntu-clock-app/fix-header-in-alarms
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Bartosz Kosiorek Approve
Review via email: mp+299624@code.launchpad.net

Commit message

Display selection header for alarms when needed

Description of the change

Fix for bug #1600487

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:477
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~mpredotka/ubuntu-clock-app/fix-header-in-alarms/+merge/299624/+edit-commit-message

https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/93/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/950/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/93/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

Works perfectly now. Thanks Michal.

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/alarm/AlarmPage.qml'
2--- app/alarm/AlarmPage.qml 2016-02-29 11:40:30 +0000
3+++ app/alarm/AlarmPage.qml 2016-07-10 09:41:30 +0000
4@@ -23,7 +23,7 @@
5 id: alarmPage
6 objectName: 'AlarmPage'
7
8- header: standardHeader
9+ header: alarmListView.ViewItems.selectMode ? selectionHeader : standardHeader
10
11 property var model: null
12 property var pageStack: null
13@@ -59,13 +59,11 @@
14
15 PageHeader {
16 id: selectionHeader
17- visible: alarmListView.ViewItems.selectMode
18 leadingActionBar.actions: [
19 Action {
20 iconName: "back"
21 text: i18n.tr("Back")
22 onTriggered: {
23- alarmPage.header = standardHeader
24 alarmListView.ViewItems.selectMode = false
25 }
26 }

Subscribers

People subscribed via source and target branches