Merge lp:~mpontillo/maas/packaging-python-apt-fix into lp:~maas-maintainers/maas/packaging

Proposed by Mike Pontillo on 2015-04-06
Status: Merged
Approved by: Mike Pontillo on 2015-04-06
Approved revision: 374
Merged at revision: 374
Proposed branch: lp:~mpontillo/maas/packaging-python-apt-fix
Merge into: lp:~maas-maintainers/maas/packaging
Diff against target: 23 lines (+2/-0)
2 files modified
debian/changelog (+1/-0)
debian/control (+1/-0)
To merge this branch: bzr merge lp:~mpontillo/maas/packaging-python-apt-fix
Reviewer Review Type Date Requested Status
Andres Rodriguez 2015-04-06 Approve on 2015-04-06
Review via email: mp+255265@code.launchpad.net

Commit message

Add python-apt to python-django-maas Depends

Description of the change

I observed this exception in the MAAS log (and an internal server error) after a fresh install of MAAS in a new LXC:

2015-04-06 01:31:21 [-] 127.0.0.1 - - [06/Apr/2015:08:31:21 +0000] "GET /MAAS/ HTTP/1.1" 302 - "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2272.118 Safari/537.36"
2015-04-06 01:31:21 [HTTPChannel,1,127.0.0.1] 500 Error - /MAAS/accounts/login/
        Traceback (most recent call last):
          File "/usr/lib/python2.7/dist-packages/django/core/handlers/wsgi.py", line 206, in __call__
            response = self.get_response(request)
          File "/usr/lib/python2.7/dist-packages/maasserver/utils/views.py", line 181, in get_response
            response = get_response(request)
          File "/usr/lib/python2.7/dist-packages/maasserver/utils/views.py", line 155, in get_response
            return django_get_response(request)
          File "/usr/lib/python2.7/dist-packages/django/core/handlers/base.py", line 194, in get_response
            response = self.handle_uncaught_exception(request, resolver, sys.exc_info())
        --- <exception caught here> ---
          File "/usr/lib/python2.7/dist-packages/django/core/handlers/base.py", line 137, in get_response
            response = response.render()
          File "/usr/lib/python2.7/dist-packages/django/template/response.py", line 105, in render
            self.content = self.rendered_content
          File "/usr/lib/python2.7/dist-packages/django/template/response.py", line 81, in rendered_content
            context = self.resolve_context(self.context_data)
          File "/usr/lib/python2.7/dist-packages/django/template/response.py", line 159, in resolve_context
            return RequestContext(self._request, context, current_app=self._current_app)
          File "/usr/lib/python2.7/dist-packages/django/template/context.py", line 168, in __init__
            for processor in get_standard_processors() + processors:
          File "/usr/lib/python2.7/dist-packages/django/template/context.py", line 148, in get_standard_processors
            func = import_by_path(path)
          File "/usr/lib/python2.7/dist-packages/django/utils/module_loading.py", line 26, in import_by_path
            sys.exc_info()[2])
          File "/usr/lib/python2.7/dist-packages/django/utils/module_loading.py", line 21, in import_by_path
            module = import_module(module_path)
          File "/usr/lib/python2.7/dist-packages/django/utils/importlib.py", line 40, in import_module
            __import__(name)
          File "/usr/lib/python2.7/dist-packages/maasserver/context_processors.py", line 24, in <module>
            from maasserver.utils.version import (
          File "/usr/lib/python2.7/dist-packages/maasserver/utils/version.py", line 20, in <module>
            import apt_pkg
        django.core.exceptions.ImproperlyConfigured: Error importing module maasserver.context_processors: "No module named apt_pkg"

We need to add python-apt to our .deb's dependencies.

To post a comment you must log in.
Andres Rodriguez (andreserl) wrote :

lgtm!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2015-04-01 12:04:24 +0000
+++ debian/changelog 2015-04-06 14:11:49 +0000
@@ -2,6 +2,7 @@
22
3 [ Mike Pontillo ]3 [ Mike Pontillo ]
4 * debian/extras/maas-region-admin: Fix Path setting.4 * debian/extras/maas-region-admin: Fix Path setting.
5 * debian/control: Properly depend on python-apt
56
6 [ Andres Rodriguez ]7 [ Andres Rodriguez ]
7 * debian/maas-dhcp.maas-dhcpd[6].service: Fix units to correctly run8 * debian/maas-dhcp.maas-dhcpd[6].service: Fix units to correctly run
89
=== modified file 'debian/control'
--- debian/control 2015-03-23 15:00:00 +0000
+++ debian/control 2015-04-06 14:11:49 +0000
@@ -180,6 +180,7 @@
180Section: python180Section: python
181Architecture: all181Architecture: all
182Depends: python-amqp,182Depends: python-amqp,
183 python-apt,
183 python-convoy,184 python-convoy,
184 python-crochet,185 python-crochet,
185 python-curtin,186 python-curtin,

Subscribers

People subscribed via source and target branches