MAAS

Merge lp:~mpontillo/maas/packaging-fix-db-purge into lp:~maas-maintainers/maas/packaging

  1. packaging-fix-db-purge
  2. Merge into packaging
Proposed by Mike Pontillo
Status: Merged
Approved by: Mike Pontillo
Approved revision: no longer in the source branch.
Merged at revision: 376
Proposed branch: lp:~mpontillo/maas/packaging-fix-db-purge
Merge into: lp:~maas-maintainers/maas/packaging
Diff against target: 25 lines (+4/-0)
2 files modified
debian/changelog (+3/-0)
debian/maas-region-controller.prerm (+1/-0)
To merge this branch: bzr merge lp:~mpontillo/maas/packaging-fix-db-purge
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Raphaël Badin (community) Approve
Review via email: mp+255330@code.launchpad.net

Commit message

Fix bug #1044559 (services must be stopped, or database cannot properly be purged)

Description of the change

Before a postgresql database can be dropped, nothing can be using it. This patch stops maas-clusterd in prerm, so that it's more likely that the purge will succeed.

To post a comment you must log in.
Revision history for this message
Raphaël Badin (rvb) wrote :

Looks good to me. I'd like Andres opinion about this but you can probably drop the "invoke-rc.d apache2 stop || true" bit now…

review: Approve
Revision history for this message
Mike Pontillo (mpontillo) wrote :

> Looks good to me. I'd like Andres opinion about this but you can probably
> drop the "invoke-rc.d apache2 stop || true" bit now...

Good point. Maybe the behavior changed when we switched from Apache. Part of me would rather leave it in, in case someone is using an old Apache config...

Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm!

review: Approve
Revision history for this message
Andres Rodriguez (andreserl) wrote :

also, I don't think we care about stopping apache2 anymore since we don';t really use it anymore.

Revision history for this message
Mike Pontillo (mpontillo) wrote :

Should we keep it in, in case we're purging an old version that is still running?

Revision history for this message
Andres Rodriguez (andreserl) wrote :

Yeah let's keep it in for the time being!

Thanks!
On Apr 8, 2015 14:59, "Mike Pontillo" <email address hidden> wrote:

> Should we keep it in, in case we're purging an old version that is still
> running?
> --
>
> https://code.launchpad.net/~mpontillo/maas/packaging-fix-db-purge/+merge/255330
> You are reviewing the proposed merge of
> lp:~mpontillo/maas/packaging-fix-db-purge into
> lp:~maas-maintainers/maas/packaging.
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-04-06 15:00:22 +0000
3+++ debian/changelog 2015-04-07 07:22:38 +0000
4@@ -2,6 +2,9 @@
5
6 * UNRELEASED
7
8+ [ Mike Pontillo ]
9+ * Stop maas-clusterd in prerm so that database purge succeeds (LP: #1044559)
10+
11 -- Andres Rodriguez <andreserl@ubuntu.com> Mon, 06 Apr 2015 11:00:00 -0400
12
13 maas (1.8.0~beta1+bzr3777-0ubuntu1) trusty; urgency=medium
14
15=== modified file 'debian/maas-region-controller.prerm'
16--- debian/maas-region-controller.prerm 2013-03-19 19:46:23 +0000
17+++ debian/maas-region-controller.prerm 2015-04-07 07:22:38 +0000
18@@ -7,6 +7,7 @@
19 #DEBHELPER#
20
21 invoke-rc.d apache2 stop || true
22+invoke-rc.d maas-regiond stop || true
23
24 . /usr/share/dbconfig-common/dpkg/prerm.pgsql
25 dbc_go maas-region-controller $@

Subscribers

People subscribed via source and target branches