Merge lp:~mpontillo/maas/display-eni-in-install-output into lp:~maas-committers/maas/trunk

Proposed by Mike Pontillo
Status: Rejected
Rejected by: Mike Pontillo
Proposed branch: lp:~mpontillo/maas/display-eni-in-install-output
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 11 lines (+1/-0)
1 file modified
contrib/preseeds_v2/curtin_userdata (+1/-0)
To merge this branch: bzr merge lp:~mpontillo/maas/display-eni-in-install-output
Reviewer Review Type Date Requested Status
Mike Pontillo (community) Disapprove
Review via email: mp+282887@code.launchpad.net

Commit message

Include /etc/network/interfaces in installation output.

To post a comment you must log in.
Revision history for this message
Mike Pontillo (mpontillo) wrote :

I triaged this enough to find this workaround, but it would be better if curtin logs this itself.

Depending on verbosity, I think curtin should log both the input network parameters, and the output /etc/network/interfaces file.

review: Disapprove
Revision history for this message
Mike Pontillo (mpontillo) wrote :

Related bug: https://bugs.launchpad.net/maas/+bug/1467673

Thanks to Blake's change, I could do:

maas <profile> maas set-config name=curtin_verbose value=true

But this is not much more helpful, as curtin does not log any additional data about how it interprets the network configuration, nor does it log the output /etc/network/interfaces.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'contrib/preseeds_v2/curtin_userdata'
2--- contrib/preseeds_v2/curtin_userdata 2015-10-30 16:03:19 +0000
3+++ contrib/preseeds_v2/curtin_userdata 2016-01-18 02:44:48 +0000
4@@ -15,6 +15,7 @@
5 {{endif}}
6 late_commands:
7 maas: [wget, '--no-proxy', '{{node_disable_pxe_url|escape.shell}}', '--post-data', '{{node_disable_pxe_data|escape.shell}}', '-O', '/dev/null']
8+ show_eni: ["curtin", "in-target", "--capture", "--", "/bin/cat", "/etc/network/interfaces"]
9 {{if third_party_drivers and driver}}
10 driver_00_key_get: curtin in-target -- sh -c "/bin/echo -en '{{key_string}}' > /tmp/maas-{{driver['package']}}.gpg"
11 driver_02_key_add: ["curtin", "in-target", "--", "apt-key", "add", "/tmp/maas-{{driver['package']}}.gpg"]