Merge ~mpontillo/maas:alternate-ntp-servers-in-dhcp--bug-1753496 into maas:master
Proposed by
Mike Pontillo
Status: | Merged |
---|---|
Approved by: | Mike Pontillo |
Approved revision: | f6eb1e941449439156745339969bb0a144983b50 |
Merge reported by: | MAAS Lander |
Merged at revision: | not available |
Proposed branch: | ~mpontillo/maas:alternate-ntp-servers-in-dhcp--bug-1753496 |
Merge into: | maas:master |
Diff against target: |
183 lines (+80/-28) 2 files modified
src/maasserver/dhcp.py (+49/-26) src/maasserver/tests/test_dhcp.py (+31/-2) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andres Rodriguez (community) | Approve | ||
MAAS Lander | Needs Fixing | ||
Review via email: mp+343152@code.launchpad.net |
Commit message
LP: #1753496 - Add NTP server for peer rack, if appropriate.
To post a comment you must log in.
I'm not familiar with how racks, etc. are represented within the MAAS code, but will this produce a list of *all* NTP servers available in the region, or just one additional from a secondary rack?
NTP best practice is to have at least 4 servers, if possible: https:/ /tools. ietf.org/ html/draft- ietf-ntp- bcp-06# section- 4.1, so if MAAS knows about more NTP servers, I think it should add them all.