Merge ~mpontillo/maas:change-subnet-fabric--bug-1755587 into maas:master

Proposed by Mike Pontillo on 2018-04-03
Status: Merged
Approved by: Mike Pontillo on 2018-04-03
Approved revision: b2881b9bf3a726e1d7ef75ff917eeea66fed493b
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~mpontillo/maas:change-subnet-fabric--bug-1755587
Merge into: maas:master
Diff against target: 13 lines (+1/-1)
1 file modified
src/maasserver/static/partials/subnet-details.html (+1/-1)
Reviewer Review Type Date Requested Status
Newell Jensen 2018-04-03 Approve on 2018-04-03
Review via email: mp+342531@code.launchpad.net

Commit message

LP #1755587 - Allow moving a subnet to a different fabric in the UI.

To post a comment you must log in.
Newell Jensen (newell-jensen) wrote :

Can this be tested?

review: Needs Information
Mike Pontillo (mpontillo) wrote :

No; there are no unit tests for this, since it was just a change to the HTML template. I did test it end-to-end and can promise you that it works!

Newell Jensen (newell-jensen) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/static/partials/subnet-details.html b/src/maasserver/static/partials/subnet-details.html
2index 8967f90..74d9c8d 100755
3--- a/src/maasserver/static/partials/subnet-details.html
4+++ b/src/maasserver/static/partials/subnet-details.html
5@@ -230,7 +230,7 @@
6 options="fabric.id as fabric.name for fabric in fabrics | orderBy:'name'"
7 label-width="2" input-width="5"></maas-obj-field>
8 <maas-obj-field type="options" key="vlan" class="u-margin--bottom" label="VLAN" placeholder="Choose VLAN"
9- options="v.id as getVLANName(v) for v in vlans | filterByFabric:subnet.fabric"
10+ options="v.id as getVLANName(v) for v in vlans | filterByFabric:subnet.$maasForm.getValue('fabric')"
11 label-width="2" input-width="5"></maas-obj-field>
12 <div class="p-form__group">
13 <div class="p-form__label">

Subscribers

People subscribed via source and target branches

to all changes: