lp:~mpontillo/curtin/fix-improper-bond-parameters-bug-1588547

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~curtin-dev/curtin/trunk at revision 390

Ryan Harper (community): Approve on 2016-06-03

Diff: 71 lines (+16/-4)

3 files modified

curtin/net/__init__.py (+10/-3)
examples/tests/bonding_network.yaml (+2/-0)
tests/unittests/test_net.py (+4/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1588547: Generated bonding configuration is incorrect.

Undecided

Fix Released

Link a bug report

Related blueprints

390. By Mike Pontillo on 2016-06-03

Don't add additional parameters to alias interfaces. (Rebase from trunk and address review comments.)

389. By Ryan Harper on 2016-05-19

Detect and remove legacy /etc/network/interfaces.d/eth0.cfg from target

Prior to Xenial release, Ubuntu Cloud images included a default network
configuration in /etc/network/interfaces.d/eth0.conf. The presence of
this legacy configuration file can cause a delay during boot when cloud-
init is expecting a non-existent interface to become available. curtin
installations handle configuring networking in the target installed
system subsequently the embedded configuration is not needed.

This patch reuses most of cloud-init's version of detecting and
examining the legacy config, confirming if the contents are what is
expected. Upon finding expected content the file will be removed,
otherwise it will remain.

Additional changes to vmtest and unittest were added to remove the
reliance on fallback nic naming (eth0); we always use non-kernel names
in our configuration now. An additional common test has been added to
check that in all cases we ensure we remove the embedded config.

388. By Ryan Harper on 2016-05-19

vmtests: Add Xenial to LVM test bucket.

387. By Scott Moser on 2016-05-06

fix timestamp in reporting events.

If no timestamp was passed into a ReportingEvent, then the default was
used. That default was 'time.time()' which was evaluated once only at
import time.

386. By Scott Moser on 2016-05-05

debian/control: add bcache-tools dependency

385. By Scott Moser on 2016-05-05

fix dependencies in packaging

This fixes up dependencies to be more correct.
The net result is that after 'apt-get install curtin', then
curtin --install-deps will not have any work to do.

curtin-common changes:
 - drop 'python' from curtin-common package as it does not use any python.
 - util-linux >= 2.20.1 is in all ubuntu (precise+) so remove this
   dependency as util-linux is 'essential'

python-curtin, python3-curtin:
 - drop 'curl' from dependencies of python-curtin or python3-curtin
   this was simply incorrect. wget is used, but curl is never.
 - explicitly list the python dependencies on oauthlib and yaml
   the attempt to have dh_python resolve these was just simply not
   working. so explicitly list them.

requirements.txt:
 - urllib3 is never used, drop it from here.
 - pbr is not needed. (it was probably copied from cloud-init)

384. By Ryan Harper on 2016-04-25

mdadm: resolve mdadm/bcache and trusty+hwe issues

- mdadm must be installed before kernel update or grub fails
- trusty bcache doesn't support sysfs entries, retry on failure
  when looking for an existing cache device
- fix storage configuration where partition 'number' key was missing
  causing curtin to use reuse a partition (configuration error).
- add some more debugging information when applying raid configurations
- raid: add in use of homehost to ensure we find the right mdadm devices
- unittests: fix up mdadm tests with introduced hostname -s call

383. By Ryan Harper on 2016-04-21

block_meta: fix previous partition size, start conversion with 4k sectors

On systems with logical_block_size = 4096, the values for size and start
in sysfs are still in 512b sector size. Handle this by converting the
sysfs values to bytes and then converting to sectors based on the logical
block size value.

Add vmtests to test when running with 4k sector sizes.

382. By Ryan Harper on 2016-04-20

curtin.net: emit source /etc/network/interfaces.d/*.cfg in eni

- Play nice with users and have eni source interfaces.d configurations.
- Fix up network unittests
  - Remove restriction in curtin's eni parser about iface redefinition;
    man (5) interfaces says this is allowed.
  - Update output of render_interfaces to account for source line
- Add vmtest to test user-defined network config in interfaces.d

381. By Ryan Harper on 2016-04-17

net: introduce 'control' field to network configuration

Allow users to specify how they want ifupdown to treat the
interface. The default value for control is 'auto' which
results in an auto $iface line in eni. If control is
'manual', then we emit a comment instead, # control-manual $iface
Any other value of control will emit a an allow-$control value.

These lines control whether ifupdown will ensure the interfaces are
up during boot. auto and hotplug ifaces will be considered a requirement
for network to be "up".

The 'manual' setting is useful for things like iscsiroot which
will configure networking in initramfs and when the root filesystem
runs, we do not want ifupdown to bring the interface used to connect
to the iscsi target up or down.