Merge lp:~mpdeimos/nuvola-player/fix-service-prefs into lp:nuvola-player/2.5.x

[Martin Pöhlmann]

I noticed some weird problem that the Service Preferences are not shown after merging your latest trunk with my google music navigation button integration. I'm not sure if this is just a problem on my installation (arch linux, 64 bit) or a global problem.

I've nailed the issue down to the commit "Removed debugging messages.". Here the line get_real_context(); has been removed. If I add this line back in, the service preferences load again.
It seems, however, that get_real_context(); has some side effects, so the fix is rather a hack imho.

[Jiří Janoušek (fenryxo)]

Hi. Thanks for noticing this bug. The backtrace of the crash has revealed the _context member of FrameBridge has not been initialized. Should be fixed in the latest trunk. Could test it?

Program received signal SIGSEGV, Segmentation fault.
JSEvaluateScript (ctx=ctx@entry=0x0, script=script@entry=0x7fff7d00d2a0, thisObject=thisObject@entry=0x0,
    sourceURL=sourceURL@entry=0x7fff6d48f9a8, startingLineNumber=startingLineNumber@entry=0,
    exception=exception@entry=0x7fffffffd518) at ../Source/JavaScriptCore/API/JSBase.cpp:47
47 ../Source/JavaScriptCore/API/JSBase.cpp: No such file or directory.
(gdb) bt
#0 JSEvaluateScript (ctx=ctx@entry=0x0, script=script@entry=0x7fff7d00d2a0, thisObject=thisObject@entry=0x0,
    sourceURL=sourceURL@entry=0x7fff6d48f9a8, startingLineNumber=startingLineNumber@entry=0,
    exception=exception@entry=0x7fffffffd518) at ../Source/JavaScriptCore/API/JSBase.cpp:47
#1 0x00007ffff7b6136a in nuvola_frame_bridge_execute_script (self=self@entry=0x7fff9422bec0,
    script=script@entry=0x10e39d0
    path=path@entry=0x1077310 "file:///home/fenryxo/dev/projects/nuvolaplayer/repo/trunk/data/nuvolaplayer/services/googleplay/settings.js", line=0, line@entry=1, result=result@entry=0x7fffffffd610, error=error@entry=0x7fffffffd608)
    at /home/fenryxo/dev/projects/nuvolaplayer/repo/trunk/src/nuvola/core/nuvola-framebridge.vala:200
#2 0x00007ffff7b617b0 in nuvola_frame_bridge_execute_script_from_file (self=self@entry=0x7fff9422bec0,
    file=file@entry=0xf59300, result=result@entry=0x7fffffffd6d0, error=error@entry=0x7fffffffd6c8)
    at /home/fenryxo/dev/projects/nuvolaplayer/repo/trunk/src/nuvola/core/nuvola-framebridge.vala:181
#3 0x00007ffff7b5c814 in nuvola_js_api_on_document_loaded (frame=<optimized out>, self=0x1112500)
    at /home/fenryxo/dev/projects/nuvolaplayer/repo/trunk/src/nuvola/core/jsapi.vala:812

review: Needs Information

[Martin Pöhlmann (mpdeimos)]

tested with latest trunk. can confirm that it is fixed.

Unmerged revisions

811. By Martin Pöhlmann on 2014-03-02

Adding get_real_context() back to ensure service
preferences are loading

=== modified file 'src/nuvola/core/nuvola-framebridge.vala'
--- src/nuvola/core/nuvola-framebridge.vala	2014-02-11 17:24:46 +0000
+++ src/nuvola/core/nuvola-framebridge.vala	2014-03-02 13:51:46 +0000
@@ -142,6 +142,7 @@
 	
 	private unowned JS.Context get_context()
 	{
+		get_real_context();
 		return _context;
 	}