Merge lp:~motoster/gwibber/gwibber into lp:gwibber

[Welton Rodrigo Torres Nascimento]

Facebook messages get their sender profile picture using type large, which is not suitable to fit into avatar squarebox.

There is a square type available on the Graph API. This merge changes a url to use this.

This is my first use of bazar, ever. Please inform if I did something wrong.

[Welton Rodrigo Torres Nascimento (motoster)]

This solves bug #1068911

[Ken VanDine (ken-vandine)]

The problem with this is the Unity preview for the gwibber lens needs 100x100 avatars. Specifying square only gets us a 50x50, perhaps it would be better to specify width and height.

For example:
https://graph.facebook.com/shaverm/picture?width=100&height=100

review: Needs Fixing

[Robert Bruce Park (robru)]

Thanks for taking the time to submit this patch, unfortunately Gwibber has gone through extensive changes recently and your patch no longer applies to the latest codebase.

Fortunately, the bug you were attempting to fix is no longer present in the current codebase. Gwibber is still downloading large avatars for the benefit of the Unity lens and the Ubuntu Touch project, but they scale nicely and do not skew when being displayed in Gwibber.

Please try out the latest Gwibber, I think you'll be quite pleased with what we've accomplished.

review: Disapprove

Unmerged revisions

1392. By Welton Rodrigo Torres Nascimento on 2012-10-20

Get square profile photos from facebook contacts.

=== modified file 'gwibber/microblog/plugins/facebook/__init__.py'
--- gwibber/microblog/plugins/facebook/__init__.py	2012-09-24 20:55:20 +0000
+++ gwibber/microblog/plugins/facebook/__init__.py	2012-10-20 02:16:21 +0000
@@ -217,7 +217,7 @@
       "name": data["name"],
       "id": str(data.get("id", '')),
       "is_me": str(data.get("id", '')) == self.user_id,
-      "image": URL_PREFIX + data["id"] + "/picture?type=large" ,
+      "image": URL_PREFIX + data["id"] + "/picture?type=square" ,
       "url": "https://www.facebook.com/profile.php?id=" + str(data.get("id", ''))
     }
     return sender