Merge ~morphis/snappy-hwe-snaps/+git/wpa-supplicant:f/disable-old-dbus-endpoint into ~snappy-hwe-team/snappy-hwe-snaps/+git/wpa-supplicant:wpa-supplicant/xenial/2.4

Proposed by Simon Fels
Status: Rejected
Rejected by: Simon Fels
Proposed branch: ~morphis/snappy-hwe-snaps/+git/wpa-supplicant:f/disable-old-dbus-endpoint
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/wpa-supplicant:wpa-supplicant/xenial/2.4
Diff against target: 19 lines (+7/-1)
1 file modified
default-config (+7/-1)
Reviewer Review Type Date Requested Status
Tony Espy Approve
System Enablement Bot continuous-integration Needs Fixing
Review via email: mp+320515@code.launchpad.net

Description of the change

SNAP: Disable old dbus endpoint to workaround a problem with snap-declarations

The store/snapd currently doesn't allow us to specify a snap-declaration
with two slots using the dbus interface. We disable the legacy endpoint
here as it isn't used by any service we support.

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Tony Espy (awe) wrote :

LGTM

review: Approve
Revision history for this message
Simon Fels (morphis) wrote :

Ok, got another updated from Jamie and we don't need to do this anymore. He got the problems fixed on the store side.

Unmerged commits

f370df0... by Simon Fels

SNAP: Disable old dbus endpoint to workaround a problem with snap-declarations

The store/snapd currently doesn't allow us to specify a snap-declaration
with two slots using the dbus interface. We disable the legacy endpoint
here as it isn't used by any service we support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/default-config b/default-config
2index 8f543d7..1ec7f94 100644
3--- a/default-config
4+++ b/default-config
5@@ -331,7 +331,13 @@ CONFIG_TLSV12=y
6
7 # Add support for old DBus control interface
8 # (fi.epitest.hostap.WPASupplicant)
9-CONFIG_CTRL_IFACE_DBUS=y
10+#
11+# SNAP: We had to disable this as currently snapd doesn't allow us to
12+# specify a snap-declaration with two slots using the dbus interface.
13+# (see LP #xxx for details)
14+#
15+# CONFIG_CTRL_IFACE_DBUS=y
16+CONFIG_CTRL_IFACE_DBUS=n
17
18 # Add support for new DBus control interface
19 # (fi.w1.hostap.wpa_supplicant1)

Subscribers

People subscribed via source and target branches

to all changes: