Merge ~morphis/snappy-hwe-snaps/+git/wifi-ap:no-external-go-deps into ~snappy-hwe-team/snappy-hwe-snaps/+git/wifi-ap:master
Proposed by
Simon Fels
Status: | Merged |
---|---|
Approved by: | Simon Fels |
Approved revision: | 4c17db7dc0251813de463c913e608d87269d729a |
Merged at revision: | ecdfb3741b0a2a849ca0b689cf3c946e31fd9b31 |
Proposed branch: | ~morphis/snappy-hwe-snaps/+git/wifi-ap:no-external-go-deps |
Merge into: | ~snappy-hwe-team/snappy-hwe-snaps/+git/wifi-ap:master |
Diff against target: |
73 lines (+50/-0) 2 files modified
parts/plugins/x-go.py (+44/-0) snapcraft.yaml (+6/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Konrad Zapałowicz (community) | Approve | ||
Alfonso Sanchez-Beato | Approve | ||
System Enablement Bot | continuous-integration | Approve | |
Review via email: mp+306448@code.launchpad.net |
Description of the change
Access go dependencies via existing debian packages
As our CI is building in an environment where access to external
services like github is not allowed we have to build with what we
get through the Ubuntu package archive. The packages we're using
here are used by the snapd debian package too so we're not basing
off something which isn't maintained.
This change will be also proposed upstream to have this available
as a general feature in snapcraft.
To post a comment you must log in.
I'm curious for some more context. What exactly was being done to get the Go dependencies before this patch? I don't fully understand why this is required and why this is a big improvement.