Merge ~morphis/snappy-hwe-snaps/+git/se-test-tools:f/add-dpkg into ~snappy-hwe-team/snappy-hwe-snaps/+git/se-test-tools:master

Proposed by Simon Fels on 2017-09-18
Status: Merged
Approved by: Konrad Zapałowicz on 2017-09-18
Approved revision: 6cfd085f242d7ae0f1fbf99cf5b7374b082e85e2
Merged at revision: 97f766e8156d23e49a05e0e08201840692dfbef2
Proposed branch: ~morphis/snappy-hwe-snaps/+git/se-test-tools:f/add-dpkg
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/se-test-tools:master
Diff against target: 18 lines (+3/-0)
1 file modified
snapcraft.yaml (+3/-0)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Approve on 2017-09-18
Alberto Milone Approve on 2017-09-18
Konrad Zapałowicz (community) code 2017-09-18 Approve on 2017-09-18
Review via email: mp+330906@code.launchpad.net

Description of the change

Add dpkg to have a handy utility on core systems to compare versions

To post a comment you must log in.
Konrad Zapałowicz (kzapalowicz) wrote :

ack

review: Approve (code)
Alberto Milone (albertomilone) wrote :

"dpkg --compare-versions" sounds like a sensible use case for having dpkg.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index 2abad80..8a2e537 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -40,6 +40,8 @@ apps:
6 command: usr/bin/mksquashfs
7 plugs:
8 - home
9+ dpkg:
10+ command: usr/bin/dpkg
11
12 parts:
13 packages:
14@@ -50,3 +52,4 @@ parts:
15 - ethtool
16 - inotify-tools
17 - squashfs-tools
18+ - dpkg

Subscribers

People subscribed via source and target branches

to all changes: