snappy-hwe-snaps

Merge ~morphis/snappy-hwe-snaps/+git/se-test-tools:add-ethtool into ~snappy-hwe-team/snappy-hwe-snaps/+git/se-test-tools:master

  1. Git
  2. lp:~morphis/snappy-hwe-snaps/+git/se-test-tools
  3. add-ethtool
  4. Merge into master
Proposed by Simon Fels
Status: Merged
Approved by: Simon Fels
Approved revision: a1f490627795088bf52276c12b795c5347f73d37
Merged at revision: e47741d6e8fc019cc28d2784fd4edef9212424e5
Proposed branch: ~morphis/snappy-hwe-snaps/+git/se-test-tools:add-ethtool
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/se-test-tools:master
Diff against target: 22 lines (+7/-0)
1 file modified
snapcraft.yaml (+7/-0)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Needs Fixing
Konrad Zapałowicz (community) code Approve
Matteo Croce (community) Approve
Review via email: mp+311800@code.launchpad.net

Description of the change

Add ethtool utility

To post a comment you must log in.
Revision history for this message
Matteo Croce (teknoraver) :
review: Approve
Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

lgtm

review: Approve (code)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:a1f490627795088bf52276c12b795c5347f73d37
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/362/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-run-snap-spread-tests/112/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/270/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/362/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index bc0ea11..6a8850c 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -22,6 +22,12 @@ apps:
6 - network-bind
7 - network-control
8 - home
9+ ethtool:
10+ command: sbin/ethtool
11+ plugs:
12+ - network
13+ - network-bind
14+ - network-control
15
16 parts:
17 packages:
18@@ -29,3 +35,4 @@ parts:
19 stage-packages:
20 - radvd
21 - isc-dhcp-server
22+ - ethtool

Subscribers

People subscribed via source and target branches

to all changes: