snappy-hwe-snaps

Merge ~morphis/snappy-hwe-snaps/+git/se-dev-tools:f/add-shyaml into ~snappy-hwe-team/snappy-hwe-snaps/+git/se-dev-tools:master

  1. Git
  2. lp:~morphis/snappy-hwe-snaps/+git/se-dev-tools
  3. f/add-shyaml
  4. Merge into master
Proposed by Simon Fels
Status: Merged
Approved by: Alfonso Sanchez-Beato
Approved revision: 56150d5137e2bb49c252af9eaadf378640c15336
Merged at revision: 08b4e32545586ce4cdf3e430263cae3b1820126a
Proposed branch: ~morphis/snappy-hwe-snaps/+git/se-dev-tools:f/add-shyaml
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/se-dev-tools:master
Diff against target: 37 lines (+9/-3)
1 file modified
snapcraft.yaml (+9/-3)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Approve
Alfonso Sanchez-Beato Approve
Review via email: mp+319913@code.launchpad.net

Description of the change

A shyaml utility to be able to query yaml files

Switch version to 1-dev

Use strict confinement / stable grade

To post a comment you must log in.
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM

review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:56150d5137e2bb49c252af9eaadf378640c15336
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1315/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/494
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1223/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/1138
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/153/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1315/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index f94d877..1e8e505 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -1,12 +1,12 @@
6 name: se-dev-tools
7-version: 0
8+version: 1-dev
9 summary: A set of utilities that help make working with our team snaps easier
10 description: |
11 This snap provides a tool to generate a snap release email as well as a
12 tool to fetch the version of a snap in the store for a given channel.
13 Please find the source code at https://code.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/se-dev-tools
14-confinement: devmode
15-grade: devel
16+confinement: strict
17+grade: stable
18
19 apps:
20 snap-revision:
21@@ -18,6 +18,8 @@ apps:
22 plugs:
23 - network
24 - home
25+ shyaml:
26+ command: bin/shyaml
27
28 parts:
29 snap-revision:
30@@ -28,3 +30,7 @@ parts:
31 plugin: go
32 source: https://github.com/canonical-system-enablement/snap-release-email-generator.git
33 source-type: git
34+ shyaml:
35+ plugin: python
36+ python-packages:
37+ - shyaml

Subscribers

People subscribed via source and target branches