Merge ~morphis/snappy-hwe-snaps/+git/network-manager:f/dnsmasq-support into ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:network-manager/xenial/1.2.2

Proposed by Simon Fels
Status: Merged
Approved by: Alfonso Sanchez-Beato
Approved revision: 82928cd3179e74d706d3e0e9b0585591c77f977e
Merged at revision: fe2cb4a09742b1ff54b43baed8ea77c5f397c4d4
Proposed branch: ~morphis/snappy-hwe-snaps/+git/network-manager:f/dnsmasq-support
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:network-manager/xenial/1.2.2
Diff against target: 13 lines (+1/-1)
1 file modified
src/dnsmasq-manager/nm-dnsmasq-manager.c (+1/-1)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Approve
Alfonso Sanchez-Beato Approve
Review via email: mp+320020@code.launchpad.net

Description of the change

Use correct path to place the dnsmasq runtime directory inside our snap environment

To post a comment you must log in.
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM

review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/dnsmasq-manager/nm-dnsmasq-manager.c b/src/dnsmasq-manager/nm-dnsmasq-manager.c
2index 764aba2..321f86f 100644
3--- a/src/dnsmasq-manager/nm-dnsmasq-manager.c
4+++ b/src/dnsmasq-manager/nm-dnsmasq-manager.c
5@@ -114,7 +114,7 @@ nm_dnsmasq_manager_new (const char *iface)
6
7 priv = NM_DNSMASQ_MANAGER_GET_PRIVATE (manager);
8 priv->iface = g_strdup (iface);
9- priv->pidfile = g_strdup_printf (RUNSTATEDIR "/nm-dnsmasq-%s.pid", iface);
10+ priv->pidfile = g_strdup_printf ("%s/nm-dnsmasq-%s.pid", nm_utils_get_run_dir(), iface);
11
12 return manager;
13 }

Subscribers

People subscribed via source and target branches