snappy-hwe-snaps

Merge ~morphis/snappy-hwe-snaps/+git/network-manager:f/add-wpa-plug into ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:master

  1. Git
  2. lp:~morphis/snappy-hwe-snaps/+git/network-manager
  3. f/add-wpa-plug
  4. Merge into master
Proposed by Simon Fels
Status: Merged
Approved by: Matteo Croce
Approved revision: a51f17d9953a9c514d2317da331e0c6e8b92539a
Merged at revision: a4bbded675ce464b50515d2c9cea69ce1e447b30
Proposed branch: ~morphis/snappy-hwe-snaps/+git/network-manager:f/add-wpa-plug
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:master
Diff against target: 24 lines (+5/-1)
1 file modified
snapcraft.yaml (+5/-1)
Reviewer Review Type Date Requested Status
Matteo Croce (community) Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+319430@code.launchpad.net

Description of the change

Add plug to be able to talk to wpa-supplicant coming from a snap

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:a51f17d9953a9c514d2317da331e0c6e8b92539a
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1259/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/328/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1166/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/5

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1259/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Matteo Croce (teknoraver) :
review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:a51f17d9953a9c514d2317da331e0c6e8b92539a
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1272/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/341
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1183/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/999
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/14

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1272/rebuild

review: Approve (continuous-integration)
Revision history for this message
Matteo Croce (teknoraver) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index 3498a9b..fc22731 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -16,6 +16,10 @@ slots:
6
7 plugs:
8 nmcli: network-manager
9+ wpa:
10+ interface: dbus
11+ bus: system
12+ name: fi.w1.wpa_supplicant1
13
14 apps:
15 nmcli:
16@@ -27,7 +31,7 @@ apps:
17 command: bin/networkmanager
18 daemon: simple
19 slots: [service]
20- plugs: [modem-manager, ppp, network-setup-observe]
21+ plugs: [modem-manager, ppp, network-setup-observe, wpa]
22 # FIXME: This will create currently a symlink inside /snap/bin
23 # which points nowhere as the service isn't exposed as application
24 # for the user. Instead snapd needs to gain support to handle

Subscribers

People subscribed via source and target branches