snappy-hwe-snaps

Merge ~morphis/snappy-hwe-snaps/+git/network-manager:feature/enable-unit-tests into ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:master

  1. Git
  2. lp:~morphis/snappy-hwe-snaps/+git/network-manager
  3. feature/enable-unit-tests
  4. Merge into master
Proposed by Simon Fels
Status: Rejected
Rejected by: Simon Fels
Proposed branch: ~morphis/snappy-hwe-snaps/+git/network-manager:feature/enable-unit-tests
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:master
Diff against target: 16 lines (+5/-0)
1 file modified
snapcraft.yaml (+5/-0)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Needs Fixing
Konrad Zapałowicz (community) Approve
Matteo Croce (community) Approve
Review via email: mp+317077@code.launchpad.net

Description of the change

Build and run unit tests with every snap build

To post a comment you must log in.
Revision history for this message
Matteo Croce (teknoraver) :
review: Approve
Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

ack

review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:c251202b51b4829189f9fa6738e2b744c68b6a19
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/897/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/804/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/897/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:c251202b51b4829189f9fa6738e2b744c68b6a19
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/907/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/815/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/907/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:c251202b51b4829189f9fa6738e2b744c68b6a19
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1125/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/128/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1033/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1125/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:c251202b51b4829189f9fa6738e2b744c68b6a19
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1155/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/183/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1063/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1155/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:c251202b51b4829189f9fa6738e2b744c68b6a19
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1176/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/224/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1083/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1176/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:c251202b51b4829189f9fa6738e2b744c68b6a19
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1177/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/225/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1085/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1177/rebuild

review: Needs Fixing (continuous-integration)

Unmerged commits

c251202... by Simon Fels

Run unit tests with every snap build

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index b809f7b..3180914 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -162,6 +162,11 @@ parts:
6 - --with-libsoup=no
7 # We want to support ModemManager
8 - --with-modem-manager-1=yes
9+ - --enable-tests=yes
10+
11+ install: |
12+ # Run all tests NetworkManager ships by default
13+ make check
14
15 # Filter files pulled in by stage-packages so they aren't
16 # included in the final snap. We only need them to build

Subscribers

People subscribed via source and target branches