Code review comment for ~morphis/snappy-hwe-snaps/+git/network-manager:powersave-configuration
Revision history for this message
| Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote | # |
review:
Needs Fixing
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
Some comments below. Two additional points:
1. Please rebase and force-push to reduce the number of commits so history is cleaner.
2. As hooks are not currently supported by snapcraft, there are additional steps for building the snap. Please comment on how to do this in README.md, or better, provide a script/makefile that makes the build.