Merge ~morphis/snappy-hwe-snaps/+git/network-manager:nm-revert-dhcp-lease-storage into ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:network-manager/xenial/1.2.2

Proposed by Simon Fels
Status: Merged
Approved by: Simon Fels
Approved revision: 45a67e26c1517ecaca71f9a71f0a77081ce65421
Merged at revision: 86a4242ca4df04841d75982b914998d5a2e3ed72
Proposed branch: ~morphis/snappy-hwe-snaps/+git/network-manager:nm-revert-dhcp-lease-storage
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:network-manager/xenial/1.2.2
Diff against target: 17 lines (+2/-4)
1 file modified
src/dhcp-manager/nm-dhcp-systemd.c (+2/-4)
Reviewer Review Type Date Requested Status
Jim Hodapp (community) Approve
Alfonso Sanchez-Beato Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+309845@code.launchpad.net

This proposal supersedes a proposal from 2016-11-02.

Description of the change

Switch back to store DHCP leases in SNAP_DATA

This depends on https://code.launchpad.net/~morphis/snappy-hwe-snaps/+git/network-manager/+merge/309847

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM

review: Approve
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/dhcp-manager/nm-dhcp-systemd.c b/src/dhcp-manager/nm-dhcp-systemd.c
2index bf2a10d..0990f3f 100644
3--- a/src/dhcp-manager/nm-dhcp-systemd.c
4+++ b/src/dhcp-manager/nm-dhcp-systemd.c
5@@ -398,10 +398,8 @@ lease_to_ip4_config (const char *iface,
6 static char *
7 get_leasefile_path (const char *iface, const char *uuid, gboolean ipv6)
8 {
9- /* Store lease files in a well-known system location so they can be
10- * read by external utilities.
11- */
12- return g_strdup_printf ("/run/NetworkManager/dhcp/internal%s-%s-%s.lease",
13+ return g_strdup_printf ("%s/dhcp/internal%s-%s-%s.lease",
14+ nm_utils_get_state_dir(),
15 ipv6 ? "6" : "",
16 uuid,
17 iface);

Subscribers

People subscribed via source and target branches