Merge ~morphis/snappy-hwe-snaps/+git/network-manager:network-manager/fix-settings-memory-leak into ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:network-manager/1.2.2

[Simon Fels]

Fix memory leak which will cause huge memory consumption over time

Changes:

 * [SNAPPY] Use static to make sure memory is only allocated once

[Simon Fels (morphis)]

CI: https://jenkins.canonical.com/system-enablement/job/generic-build-snap/31/

[Tony Espy (awe)]

LGTM

review: Approve

diff --git a/src/settings/nm-settings-connection.c b/src/settings/nm-settings-connection.c
index 3830769..d2504f9 100644
--- a/src/settings/nm-settings-connection.c
+++ b/src/settings/nm-settings-connection.c
@@ -38,7 +38,7 @@
 
 static const char *get_settings_timestamps_path()
 {
-	const char *timestamps_path = NULL;
+	static const char *timestamps_path = NULL;
 
 	if (!timestamps_path)
 		timestamps_path = g_strdup_printf("%s/timestamps", nm_utils_get_state_dir());
@@ -48,7 +48,7 @@ static const char *get_settings_timestamps_path()
 
 static const char *get_settings_seen_bssids_path()
 {
-	const char *seen_bssids_path = NULL;
+	static const char *seen_bssids_path = NULL;
 
 	if (!seen_bssids_path)
 		seen_bssids_path = g_strdup_printf("%s/seen-bssids", nm_utils_get_state_dir());