snappy-hwe-snaps

Merge ~morphis/snappy-hwe-snaps/+git/location-service:snapcraft-improvements into ~snappy-hwe-team/snappy-hwe-snaps/+git/locationd:master

  1. Git
  2. lp:~morphis/snappy-hwe-snaps/+git/location-service
  3. snapcraft-improvements
  4. Merge into master
Proposed by Simon Fels
Status: Merged
Approved by: Roberto Mier Escandon
Approved revision: c0726cc5301c667a6490aa476abef31bee934c1a
Merged at revision: ce071be69672aeec69b7d14b922f73075ad3c44d
Proposed branch: ~morphis/snappy-hwe-snaps/+git/location-service:snapcraft-improvements
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/locationd:master
Diff against target: 26 lines (+4/-1)
1 file modified
snapcraft.yaml (+4/-1)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Approve
Roberto Mier Escandon (community) Approve
Review via email: mp+331567@code.launchpad.net

Description of the change

Small set of snapcraft.yaml improvements

 * Run unit tests as additional test execution step
 * Use prime keyword instead of deprecated snap one
 * Define snap grade

To post a comment you must log in.
Revision history for this message
Simon Fels (morphis) wrote :

Ah damn it, MP was against wrong repository that is why these showed up here.

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: c0726cc5301c667a6490aa476abef31bee934c1a

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/660/

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: c0726cc5301c667a6490aa476abef31bee934c1a

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/661/

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: c0726cc5301c667a6490aa476abef31bee934c1a

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/662/

Revision history for this message
Roberto Mier Escandon (rmescandon) :
review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: c0726cc5301c667a6490aa476abef31bee934c1a

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/663/

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:c0726cc5301c667a6490aa476abef31bee934c1a
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/18/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/18
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/18
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/18
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/18

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/18/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index ebf15a2..8fbe3f9 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -1,6 +1,7 @@
6 name: locationd
7 version: 4.2.0-dev
8 confinement: strict
9+grade: stable
10 summary: Location service mediates access to positioning providers.
11 description: |
12 Location service mediates access to positioning providers.
13@@ -85,10 +86,12 @@ parts:
14 - trust-store-bin
15 stage-packages:
16 - geoclue-ubuntu-geoip
17+ install: |
18+ make test
19 filesets:
20 licenses:
21 - usr/share/doc/*/*copyright*
22- snap:
23+ prime:
24 - bin/locationd
25 - etc/dbus-1/system.d
26 - lib/

Subscribers

People subscribed via source and target branches

to all changes: