Merge ~morphis/snappy-hwe-snaps/+git/jenkins-jobs:skip-tests-on-non-amd64 into ~snappy-hwe-team/snappy-hwe-snaps/+git/jenkins-jobs:master

Proposed by Simon Fels
Status: Merged
Approved by: Jim Hodapp
Approved revision: 3c1f55685a9b896e1710861656c36cbbd46b26b5
Merged at revision: 40d17b7c502a54d3512e0cc96976bd14a24292f7
Proposed branch: ~morphis/snappy-hwe-snaps/+git/jenkins-jobs:skip-tests-on-non-amd64
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/jenkins-jobs:master
Diff against target: 31 lines (+9/-0)
2 files modified
jobs/snap/snap-test.sh (+5/-0)
jobs/snap/snap-test.yaml (+4/-0)
Reviewer Review Type Date Requested Status
Jim Hodapp (community) Approve
System Enablement Bot continuous-integration Approve
Roberto Mier Escandon (community) Approve
Review via email: mp+331200@code.launchpad.net

Description of the change

jobs/snap: disable test execution when specified architecture is not amd64

The current setup doesn't support any other architectures than amd64
at the moment.

To post a comment you must log in.
Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

lgtm

review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/jobs/snap/snap-test.sh b/jobs/snap/snap-test.sh
2index 6e4ab9f..752b375 100644
3--- a/jobs/snap/snap-test.sh
4+++ b/jobs/snap/snap-test.sh
5@@ -18,6 +18,11 @@ set -ex
6
7 . "$WORKSPACE/.build_env"
8
9+if [ -z "$ARCHITECTURE" ] || [ "$ARCHITECTURE" != amd64 ] ; then
10+ echo "WARNING: Skipping tests as only supported on amd64 for the moment"
11+ exit 0
12+fi
13+
14 if [ "$RUN_TESTS" = False ]; then
15 echo "WARNING: test execution is disabled"
16 exit 0
17diff --git a/jobs/snap/snap-test.yaml b/jobs/snap/snap-test.yaml
18index a361bbd..9cc5cea 100644
19--- a/jobs/snap/snap-test.yaml
20+++ b/jobs/snap/snap-test.yaml
21@@ -8,6 +8,10 @@
22 node: snap && test
23 parameters:
24 - string:
25+ name: ARCHITECTURE
26+ default: ""
27+ description: "Architecture to run tests on"
28+ - string:
29 name: SOURCE_GIT_REPO
30 default: ""
31 description: "Source git repository"

Subscribers

People subscribed via source and target branches

to all changes: