Merge ~morphis/snappy-hwe-snaps/+git/jenkins-jobs:f/correct-jlp-arrray-param into ~snappy-hwe-team/snappy-hwe-snaps/+git/jenkins-jobs:master

Proposed by Simon Fels
Status: Merged
Approved by: Konrad ZapaƂowicz
Approved revision: 9de7d728020d50cfa605e3276dfaf66b3eabb5c1
Merged at revision: 086bc3216089d2d3c19c91957b2853c6fb2384ba
Proposed branch: ~morphis/snappy-hwe-snaps/+git/jenkins-jobs:f/correct-jlp-arrray-param
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/jenkins-jobs:master
Diff against target: 14 lines (+1/-2)
1 file modified
jobs/infrastructure/credentials-2-launchpad-plugin.sh (+1/-2)
Reviewer Review Type Date Requested Status
Alfonso Sanchez-Beato Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+330803@code.launchpad.net

Description of the change

jobs/infrastructure: put template var into same line to prevent invalid yaml

We ended up with

 jobs_blacklisted_from_messages: ""

with the current configuration but the variable needs to be an array.
The previous template didn't allow us to pass an empty array but with
keeping everything on the same line we can now set the variable to []
and generate a valid yaml file.

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/jobs/infrastructure/credentials-2-launchpad-plugin.sh b/jobs/infrastructure/credentials-2-launchpad-plugin.sh
2index b963c69..59dd324 100644
3--- a/jobs/infrastructure/credentials-2-launchpad-plugin.sh
4+++ b/jobs/infrastructure/credentials-2-launchpad-plugin.sh
5@@ -62,8 +62,7 @@ jenkins_build_token: "BUILD_ME"
6
7 # console output from the following jobs will not be printed to the
8 # affected merge proposal (in the "Executed test runs:" section)
9-jobs_blacklisted_from_messages:
10-{blacklisted_jobs}
11+jobs_blacklisted_from_messages: {blacklisted_jobs}
12
13 #message that is used for "testing in progress" comment
14 launchpad_build_in_progress_message: "Jenkins: testing in progress"

Subscribers

People subscribed via source and target branches

to all changes: