Merge ~morphis/snappy-hwe-snaps/+git/engineering-tests:dont-use-pip into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

Proposed by Simon Fels
Status: Rejected
Rejected by: Simon Fels
Proposed branch: ~morphis/snappy-hwe-snaps/+git/engineering-tests:dont-use-pip
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master
Prerequisite: ~morphis/snappy-hwe-snaps/+git/engineering-tests:extend-nm-tests
Diff against target: 36 lines (+16/-4)
1 file modified
snapcraft.yaml (+16/-4)
Reviewer Review Type Date Requested Status
Simon Fels Disapprove
Jim Hodapp (community) Approve
System Enablement Bot continuous-integration Needs Fixing
Review via email: mp+312240@code.launchpad.net

Description of the change

Rework snapcraft build to not use pip

Accessing pip isn't possible in our CI environment so we just fetch
plainbox from launchpad and any relevant dependencies from the archive

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

What is pip exactly?

review: Needs Information
Revision history for this message
Scott Sweeny (ssweeny) wrote :

Pip is python's package manager. Equivalent to something like npm.

https://en.wikipedia.org/wiki/Pip_(package_manager)

Revision history for this message
Jim Hodapp (jhodapp) wrote :

Oh that's right, I remember that now. I hardly ever use Python.

Revision history for this message
Simon Fels (morphis) wrote :

Yeah, however this doesn't work yet. Need to see if I can change the python plugin a bit more to only use local things.

Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve
Revision history for this message
Simon Fels (morphis) wrote :

Blocking until CI is happy

review: Disapprove

Unmerged commits

f31315d... by Simon Fels

Rework snapcraft build to not use pip

Accessing pip isn't possible in our CI environment so we just fetch
plainbox from launchpad and any relevant dependencies from the archive.

8ebed11... by Simon Fels

Respect review comments

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index af4f8c5..3555e25 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -38,15 +38,27 @@ parts:
6 - COPYING
7 plainbox-local:
8 plugin: python
9- python-packages:
10- - plainbox
11- - requests-oauthlib
12- - xlsxwriter
13+ source: https://git.launchpad.net/plainbox
14+ source-type: git
15+ source-tag: v0.31
16 build-packages:
17 - libxml2-dev
18 - libxslt1-dev
19 - zlib1g-dev
20 - build-essential
21+ - python3-all
22+ - python3-distutils-extra
23+ - python3-docutils
24+ - python3-guacamole
25+ - python3-jinja2
26+ - python3-padme
27+ - python3-pkg-resources
28+ - python3-requests
29+ - python3-requests-oauthlib
30+ - python3-setuptools
31+ - python3-sphinx
32+ - python3-tk
33+ - python3-xlsxwriter
34 se-plainbox-provider:
35 plugin: plainbox-provider
36 source: ./tests

Subscribers

People subscribed via source and target branches

to all changes: