Merge ~morphis/snappy-hwe-snaps/+git/build-scripts:b/replace-only-real-version into ~snappy-hwe-team/snappy-hwe-snaps/+git/build-scripts:master

Proposed by Simon Fels
Status: Merged
Approved by: Alfonso Sanchez-Beato
Approved revision: 3670fe5ecad62192949164990380f9577d3b142f
Merged at revision: abc551765a7a470d3e3e794bcef8ec1055370f79
Proposed branch: ~morphis/snappy-hwe-snaps/+git/build-scripts:b/replace-only-real-version
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/build-scripts:master
Diff against target: 12 lines (+1/-1)
1 file modified
jobs/generic-release-snap (+1/-1)
Reviewer Review Type Date Requested Status
Alfonso Sanchez-Beato Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+320147@code.launchpad.net

Description of the change

Only replace version: fields in snapcraft.yaml when the line starts with it

This ignores other fields having 'version:' in it like 'python-version:'

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/jobs/generic-release-snap b/jobs/generic-release-snap
2index 334b4db..fffc8fb 100755
3--- a/jobs/generic-release-snap
4+++ b/jobs/generic-release-snap
5@@ -42,7 +42,7 @@ fi
6 git config user.name "System Enablement CI Bot"
7 git config user.email "ce-system-enablement@lists.canonical.com"
8
9-sed -i -e "s/version:\ .*/version: $VERSION/g" snapcraft.yaml
10+sed -i -e "s/^version:\ .*/version: $VERSION/g" snapcraft.yaml
11 git add snapcraft.yaml
12 git commit -m "Bump version to $VERSION"
13

Subscribers

People subscribed via source and target branches

to all changes: