Merge ~morphis/snappy-hwe-snaps/+git/build-scripts:f/switch-to-dev-after-release into ~snappy-hwe-team/snappy-hwe-snaps/+git/build-scripts:master

Proposed by Simon Fels
Status: Superseded
Proposed branch: ~morphis/snappy-hwe-snaps/+git/build-scripts:f/switch-to-dev-after-release
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/build-scripts:master
Diff against target: 15 lines (+6/-0)
1 file modified
jobs/generic-release-snap (+6/-0)
Reviewer Review Type Date Requested Status
Alfonso Sanchez-Beato Needs Fixing
Konrad Zapałowicz (community) code Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+319542@code.launchpad.net

Description of the change

Use new parameter NEXT_VERSION to bump version for the next cycle

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

ack

review: Approve (code)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Besides the inline comment, I am a bit concerned that we do not know which would be the next version name. We could move from, say PA 8.0 to 9.0 but do not know when doing the release of 8.0-X. If we assume that the version can change in a future commit I guess it is fine though.

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/jobs/generic-release-snap b/jobs/generic-release-snap
2index 45d7507..62ab7f7 100755
3--- a/jobs/generic-release-snap
4+++ b/jobs/generic-release-snap
5@@ -58,4 +58,10 @@ git push origin stable
6 git push origin master
7 git push origin $VERSION
8
9+git checkout master
10+sed -i -e "s/version:\ .*/version: ${NEXT_VERSION}-dev/g" snapcraft.yaml
11+git add snapcraft.yaml
12+git commit -m "Open development for ${NEXT_VERSION}-dev"
13+git push origin master
14+
15 exec $WORKSPACE/build-scripts/scripts/trigger-lp-build.py -s $SNAP_NAME -p

Subscribers

People subscribed via source and target branches

to all changes: