Code review comment for ~morphis/netplan/+git/netplan:nm-snap-support

Revision history for this message
Martin Pitt (pitti) wrote :

I'm sorry, but this is just broken. That binary name is being used way more widely than the .service name. If you want to credibly provide an OS component as a snap, then this also must provide the expected API, CLI, etc. to the user. Note that it already is not possible to install this on touch, or a "personal" snappy device etc. which has network-manager.deb installed. I. e. it's going to clash anyway, so you can as well provide the proper executable names.

review: Disapprove

« Back to merge proposal