lp:~morphis/charm-haproxy/fix-port-comparison

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:charm-haproxy at revision 149

Tom Haddon: Approve on 2021-11-05

Canonical IS Reviewers: Pending requested 2021-11-05

Diff: 12 lines (+1/-1)

1 file modified

hooks/hooks.py (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

149. By Simon Fels on 2021-11-05

Convert port to integer to allow comparison

The update_service_ports method compares ports from both supplied lists. One list
is coming from get_service_ports which keeps ports as integer and the other one
from config_changed which keeps them as utf8 strings. Comparing ports will now fail
inside update_service_ports as we compare integers vs strings.

With Juju 2.9 this leads to ports randomly being opened as semantics on
open-port/close-port have slightly changed.

We saw ports being never opened after initial deployment in a 2.9 model with the
services config option set. Only after remove-relation/relate we were able to get
the ports correctly exposed.

Fixing the port comparison resolves this and makes things work on both Juju 2.8 and 2.9

148. By Vern Hart on 2021-10-19

Simplify install hook (works on bionic and focal).

Fixes: https://bugs.launchpad.net/charm-haproxy/+bug/1946798

Reviewed-on: https://code.launchpad.net/~vern/charm-haproxy/fix-install-hook/+merge/410140
Reviewed-by: Tom Haddon <email address hidden>
Reviewed-by: Paul Collins <email address hidden>

147. By Junien F on 2021-10-13

we want to install the python2 package for focal and above, not the other way around

Reviewed-on: https://code.launchpad.net/~axino/charm-haproxy/trunk/+merge/410129
Reviewed-by: Joel Sing <email address hidden>

146. By Haw Loeung on 2021-10-13

Fix distro/release detection - LP:1946798

Reviewed-on: https://code.launchpad.net/~hloeung/charm-haproxy/fix-distro-release-detection/+merge/410096
Reviewed-by: Paul Collins <email address hidden>

145. By Tom Haddon on 2021-10-11

Update README to document monitoring via Telegraf, use 'relate' rather than 'add-relation' and remove personal pronoun

Reviewed-on: https://code.launchpad.net/~mthaddon/charm-haproxy/doc-updates/+merge/409521
Reviewed-by: Loïc Gomez <email address hidden>

144. By Thomas Cuthbert on 2021-10-11

fix: general fixes for using correct python version.

Reviewed-on: https://code.launchpad.net/~tcuthbert/charm-haproxy/haproxy-focal/+merge/409962
Reviewed-by: Joel Sing <email address hidden>

143. By Haw Loeung on 2020-08-28

Bump DH params used, it's year 2020

Reviewed-on: https://code.launchpad.net/~hloeung/charm-haproxy/bump-global-dh-param/+merge/388543
Reviewed-by: Tom Haddon <email address hidden>

142. By Ponnuvel Palaniyappan on 2020-08-11

Don't include haproxy check scripts if monitoring is disabled.

Reviewed-on: https://code.launchpad.net/~pponnuvel/charm-haproxy/charm-haproxy/+merge/388506
Reviewed-by: Tom Haddon <email address hidden>

141. By Simon Fels on 2020-07-13

Bump key bits to 2048

As of Ubuntu 20.04 OpenSSL requires at minimum a 2048 bit key. See
https://wiki.debian.org/ContinuousIntegration/TriagingTips/openssl-1.1.1

Reviewed-on: https://code.launchpad.net/~morphis/charm-haproxy/fix-tls-on-focal/+merge/387279
Reviewed-by: Joel Sing <email address hidden>

140. By Benjamin Allot on 2020-04-02

Separate the haproxy queue alert and the maximum threshold exceeded.

Reviewed-on: https://code.launchpad.net/~ballot/charm-haproxy/max_queue/+merge/381567
Reviewed-by: Tom Haddon <email address hidden>
Reviewed-by: Junien Fridrick <email address hidden>