Merge lp:~morphis/aethercast/small-fixes into lp:aethercast

[Simon Fels]

Fix RTSP debugging and device state update reporting

Due to previous search&replace operations the environment variable we are using to enable RTSP debugging was corrupted and is now correctly named AETHERCAST_RTSP_DEBUG. Furthermore we were only reporting device state updates for the current device but should really report them for every device regardless if its the current one or not.

[Alfonso Sanchez-Beato (alfonsosanchezbeato)]

LGTM

review: Approve

[Matteo Croce (teknoraver)]

review: Approve

[lp:~morphis/aethercast/small-fixes]

151. By Simon Fels on 2016-07-14

Use commong ac::utils::IsEnvSet

152. By Simon Fels on 2016-07-14

Use correct namespace

[Konrad Zapałowicz (kzapalowicz)]

LGTM

review: Approve (code)

=== modified file 'src/ac/service.cpp'
--- src/ac/service.cpp	2016-06-07 08:21:20 +0000
+++ src/ac/service.cpp	2016-07-14 08:49:14 +0000
@@ -385,13 +385,13 @@
           device->Address(),
           ac::NetworkDevice::StateToStr(device->State()));
 
+    if (auto sp = delegate_.lock())
+        sp->OnDeviceChanged(device);
+
     if (device != current_device_)
         return;
 
     AdvanceState(device->State());
-
-    if (auto sp = delegate_.lock())
-        sp->OnDeviceChanged(device);
 }
 
 void Service::OnDeviceChanged(const NetworkDevice::Ptr &device) {

=== modified file 'src/ac/sourceclient.cpp'
--- src/ac/sourceclient.cpp	2016-06-07 08:21:20 +0000
+++ src/ac/sourceclient.cpp	2016-07-14 08:49:14 +0000
@@ -66,8 +66,7 @@
 }
 
 void SourceClient::DumpRtsp(const std::string &prefix, const std::string &data) {
-    static bool enabled = getenv("MIRACAST_RTSP_AC_DEBUG") != nullptr;
-
+    static bool enabled = Utils::IsEnvSet("AETHERCAST_RTSP_DEBUG");
     if (!enabled)
         return;