Merge lp:~mordred/drizzle/require-haildb-not-embedded-innodb into lp:~drizzle-trunk/drizzle/development

Proposed by Monty Taylor
Status: Merged
Approved by: Brian Aker
Approved revision: 1807
Merged at revision: 1817
Proposed branch: lp:~mordred/drizzle/require-haildb-not-embedded-innodb
Merge into: lp:~drizzle-trunk/drizzle/development
Diff against target: 104 lines (+25/-42)
3 files modified
m4/pandora_have_libhaildb.m4 (+23/-40)
plugin/haildb/plugin.ac (+1/-1)
plugin/haildb/plugin.ini (+1/-1)
To merge this branch: bzr merge lp:~mordred/drizzle/require-haildb-not-embedded-innodb
Reviewer Review Type Date Requested Status
Drizzle Merge Team Pending
Review via email: mp+37559@code.launchpad.net

Description of the change

Change the requirement from either libinnodb to libhaildb. Also, tied it to 2.2. No need to support ancient history.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== renamed file 'm4/pandora_have_libinnodb.m4' => 'm4/pandora_have_libhaildb.m4'
2--- m4/pandora_have_libinnodb.m4 2010-09-19 18:20:17 +0000
3+++ m4/pandora_have_libhaildb.m4 2010-10-05 06:51:11 +0000
4@@ -3,58 +3,41 @@
5 dnl gives unlimited permission to copy and/or distribute it,
6 dnl with or without modifications, as long as this notice is preserved.
7
8-AC_DEFUN([_PANDORA_SEARCH_LIBINNODB],[
9+AC_DEFUN([_PANDORA_SEARCH_LIBHAILDB],[
10 AC_REQUIRE([AC_LIB_PREFIX])
11
12 dnl --------------------------------------------------------------------
13- dnl Check for libhaildb or libinnodb
14+ dnl Check for libhaildb
15 dnl --------------------------------------------------------------------
16
17- AC_ARG_ENABLE([libinnodb],
18- [AS_HELP_STRING([--disable-libinnodb],
19- [Build with libinnodb support @<:@default=on@:>@])],
20- [ac_enable_libinnodb="$enableval"],
21- [ac_enable_libinnodb="yes"])
22-
23-
24- AS_IF([test "x$ac_enable_libinnodb" = "xyes"],[
25+ AC_ARG_ENABLE([libhaildb],
26+ [AS_HELP_STRING([--disable-libhaildb],
27+ [Build with libhaildb support @<:@default=on@:>@])],
28+ [ac_enable_libhaildb="$enableval"],
29+ [ac_enable_libhaildb="yes"])
30+
31+
32+ AS_IF([test "x$ac_enable_libhaildb" = "xyes"],[
33 AC_LIB_HAVE_LINKFLAGS(haildb,,[
34 #include <haildb.h>
35 ],[
36- ib_u64_t
37- ib_api_version(void);
38+ ib_set_panic_handler(NULL);
39 ])
40 AS_IF([test "x${ac_cv_libhaildb}" = "xyes"],[
41 AC_DEFINE([HAVE_HAILDB_H],[1],[Do we have haildb.h])
42- INNODB_LIBS="${LTLIBHAILDB}"
43- ac_cv_have_innodb=yes
44- ],[
45- AC_LIB_HAVE_LINKFLAGS(innodb,,[
46- #include <embedded_innodb-1.0/innodb.h>
47- ],[
48- ib_u64_t
49- ib_api_version(void);
50- ])
51- AS_IF([test "x${ac_cv_libinnodb}" = "xyes"],[
52- AC_DEFINE([HAVE_INNODB_H],[1],[Do we have innodb.h])
53- INNODB_LIBS="${LTLIBINNODB}"
54- ac_cv_have_innodb=yes
55- ])
56- ])
57+ ])
58 ],[
59 ac_cv_libhaildb="no"
60- ac_cv_libinnodb="no"
61 ])
62- AC_SUBST([INNODB_LIBS])
63- AM_CONDITIONAL(HAVE_LIBINNODB, [test "x${ac_cv_have_innodb}" = "xyes"])
64-])
65-
66-AC_DEFUN([PANDORA_HAVE_LIBINNODB],[
67- AC_REQUIRE([_PANDORA_SEARCH_LIBINNODB])
68-])
69-
70-AC_DEFUN([PANDORA_REQUIRE_LIBINNODB],[
71- AC_REQUIRE([PANDORA_HAVE_LIBINNODB])
72- AS_IF([test "x${ac_cv_libinnodb}" = "xno"],
73- AC_MSG_ERROR([libhaildb or libinnodb is required for ${PACKAGE}]))
74+ AM_CONDITIONAL(HAVE_LIBHAILDB, [test "x${ac_cv_libhaildb}" = "xyes"])
75+])
76+
77+AC_DEFUN([PANDORA_HAVE_LIBHAILDB],[
78+ AC_REQUIRE([_PANDORA_SEARCH_LIBHAILDB])
79+])
80+
81+AC_DEFUN([PANDORA_REQUIRE_LIBHAILDB],[
82+ AC_REQUIRE([PANDORA_HAVE_LIBHAILDB])
83+ AS_IF([test "x${ac_cv_libhaildb}" = "xno"],
84+ AC_MSG_ERROR([libhaildb 2.2.0 or later is required for ${PACKAGE}]))
85 ])
86
87=== modified file 'plugin/haildb/plugin.ac'
88--- plugin/haildb/plugin.ac 2010-02-08 03:36:14 +0000
89+++ plugin/haildb/plugin.ac 2010-10-05 06:51:11 +0000
90@@ -1,1 +1,1 @@
91-PANDORA_HAVE_LIBINNODB
92\ No newline at end of file
93+PANDORA_HAVE_LIBHAILDB
94
95=== modified file 'plugin/haildb/plugin.ini'
96--- plugin/haildb/plugin.ini 2010-09-30 05:47:49 +0000
97+++ plugin/haildb/plugin.ini 2010-10-05 06:51:11 +0000
98@@ -4,5 +4,5 @@
99 sources=haildb_engine.cc haildb_version_func.cc haildb_datadict_dump_func.cc config_table_function.cc status_table_function.cc datadict_table_message.cc
100 headers=haildb_engine.h haildb_version_func.h haildb_datadict_dump_func.h config_table_function.h status_table_function.h
101 build_conditional="x${ac_cv_have_innodb}" = "xyes"
102-ldflags=${INNODB_LIBS}
103+ldflags=${LTLIBHAILDB}
104 extra_dist=test-suite-dir