Merge lp:~mordred/drizzle/clean-doco into lp:~drizzle-trunk/drizzle/development

Proposed by Monty Taylor
Status: Merged
Approved by: Monty Taylor
Approved revision: 1806
Merged at revision: 1813
Proposed branch: lp:~mordred/drizzle/clean-doco
Merge into: lp:~drizzle-trunk/drizzle/development
Diff against target: 465 lines (+300/-36)
6 files modified
docs/index.rst (+0/-1)
docs/options.rst (+290/-1)
docs/protocol.rst (+7/-9)
drizzled/drizzled.cc (+3/-23)
drizzled/set_var.cc (+0/-1)
drizzled/set_var.h (+0/-1)
To merge this branch: bzr merge lp:~mordred/drizzle/clean-doco
Reviewer Review Type Date Requested Status
Andrew Hutchings Approve
Drizzle Merge Team Pending
Review via email: mp+37040@code.launchpad.net

Description of the change

Updates to documentation and removal of some unused options.

To post a comment you must log in.
Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

Fantastic start to the docs!

review: Approve
lp:~mordred/drizzle/clean-doco updated
1803. By Brian Aker <email address hidden>

Adding environmental table to utility schema.

1804. By Brian Aker <email address hidden>

1) Fixed a couple of tests that were still relying on counts of tables in
schemas.
2) Removed utility dictionary from being loaded automatically.

1805. By Brian Aker

Merge to trunk.

1806. By Monty Taylor

Merged up with trunk.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'docs/index.rst'
2--- docs/index.rst 2010-09-26 21:24:38 +0000
3+++ docs/index.rst 2010-10-04 22:47:14 +0000
4@@ -49,6 +49,5 @@
5 ==================
6
7 * :ref:`genindex`
8-* :ref:`modindex`
9 * :ref:`search`
10
11
12=== modified file 'docs/options.rst'
13--- docs/options.rst 2010-09-26 20:42:38 +0000
14+++ docs/options.rst 2010-10-04 22:47:14 +0000
15@@ -1,8 +1,297 @@
16-
17 Drizzled Options
18 ================
19
20 There are many different options one can use to configure Drizzle.
21
22+Config File Options
23+-------------------
24+
25+.. option:: --help-extended
26+ Display this help and exit after initializing plugins.
27+
28+.. option:: -?,--help
29+ Display this help and exit.
30+
31+.. option:: --no-defaults
32+ Configuration file defaults are not used if no-defaults is set
33+
34+.. option:: --defaults-file arg
35+ Configuration file to use
36+
37+.. option:: --config-dir arg (=/etc/drizzle)
38+ Base location for config files
39+
40+.. option:: --plugin-dir arg
41+ Directory for plugins
42+
43+.. option:: --pid-file arg
44+
45+ Pid file used by drizzled.
46+
47+Plugin Loading Options
48+----------------------
49+
50+.. option:: --plugin-add arg
51+ Optional comma separated list of plugins to load at startup in addition
52+ to the default list of plugins.
53+
54+ for example: --plugin_add=crc32,console,pbxt
55+
56+.. option:: --plugin-remove arg
57+ Optional comma separated list of plugins to not load at startup.
58+ Effectively removes a plugin from the list of plugins to be loaded.
59+
60+ for example: --plugin_remove=syslog,md5
61+
62+.. option:: --plugin-load arg (=version,uuid_function,user_function,transaction_log,syslog,substr_functions,sleep,show_schema_proto,rot13,reverse_function,rand_function,multi_thread,md5,logging_stats,length,hex_functions,hello_world,filtered_replicator,errmsg_stderr,default_replicator,database_function,crc32,connection_id,compression,charlength,benchmark,ascii,)
63+
64+ Optional comma separated list of plugins to load at starup instead of
65+ the default plugin load list. This completely replaces the whole list.
66+
67 Kernel Options
68 --------------
69+
70+.. option:: --auto-increment-increment arg (=1)
71+
72+ Auto-increment columns are incremented by this
73+
74+.. option:: --auto-increment-offset arg (=1)
75+
76+ Offset added to Auto-increment columns.
77+ Used when auto-increment-increment != 1
78+
79+.. option:: -b,--basedir arg
80+
81+ Path to installation directory.
82+ All paths are usually resolved relative to this.
83+
84+.. option:: -r,--chroot arg
85+
86+ Chroot drizzled daemon during startup.
87+
88+.. option:: --collation-server arg
89+
90+ Set the default collation.
91+
92+.. option:: --completion-type arg (=0)
93+
94+ Default completion type.
95+
96+.. option:: --core-file
97+
98+ Write core on errors.
99+
100+.. option:: --datadir arg
101+
102+ Path to the database root.
103+
104+.. option:: --default-storage-engine arg
105+
106+ Set the default storage engine for tables.
107+
108+.. option:: --default-time-zone arg
109+
110+ Set the default time zone.
111+
112+.. We should really remove --exit-info as an option
113+.. option:: -T,--exit-info arg
114+
115+ Used for debugging; Use at your own risk!
116+
117+.. option:: --gdb
118+
119+ Set up signals usable for debugging
120+
121+.. option:: --lc-time-name arg
122+
123+ Set the language used for the month names and the days of the week.
124+
125+.. option:: -W [ --log-warnings ] arg
126+
127+ Log some not critical warnings to the log file.
128+
129+.. Why is this a core argument?
130+.. option:: --port-open-timeout arg (=0)
131+
132+ Maximum time in seconds to wait for the port to become free.
133+ A value of 0 means not to wait.
134+
135+.. option:: --secure-file-priv arg
136+
137+ Limit LOAD DATA, SELECT ... OUTFILE, and LOAD_FILE() to files within
138+ specified directory
139+
140+.. Why is this still here?
141+.. option:: --server-id arg (=0)
142+
143+ Uniquely identifies the server instance in the community of replication
144+ partners.
145+
146+.. option:: --skip-stack-trace
147+
148+ Don't print a stack trace on failure.
149+
150+.. option:: -s,--symbolic-links
151+
152+ Enable symbolic link support.
153+
154+.. option:: --timed-mutexes
155+
156+ Specify whether to time mutexes (only InnoDB mutexes are currently supported)
157+
158+.. option:: -t,--tmpdir arg
159+
160+ Path for temporary files.
161+
162+.. option:: --transaction-isolation arg
163+
164+ Default transaction isolation level.
165+
166+.. option:: -u,--user arg
167+
168+ Run drizzled daemon as user.
169+
170+.. option:: -V,--version
171+
172+ Output version information and exit.
173+
174+.. option:: --back-log arg (=50)
175+
176+ The number of outstanding connection requests Drizzle can have. This comes
177+ into play when the main Drizzle thread gets very many connection requests in
178+ a very short time.
179+
180+.. option:: --bulk-insert-buffer-size arg (=8388608)
181+
182+ Size of tree cache used in bulk insert optimization. Note that this is a limit
183+ per thread!
184+
185+.. option:: --div-precision-increment arg (=4)
186+
187+ Precision of the result of '/' operator will be increased on that value.
188+
189+.. option:: --group-concat-max-len arg (=1024)
190+
191+ The maximum length of the result of function group_concat.
192+
193+.. option:: --join-buffer-size arg (=131072)
194+
195+ The size of the buffer that is used for full joins.
196+
197+.. Why is this a core arg?
198+.. option:: --max-allowed-packet arg (=1M)
199+
200+ Max packetlength to send/receive from to server.
201+
202+.. option:: --max-connect-errors arg (=10)
203+
204+ If there is more than this number of interrupted connections from a host
205+ this host will be blocked from further connections.
206+
207+.. option:: --max-error-count arg (=64)
208+
209+ Max number of errors/warnings to store for a statement.
210+
211+.. option:: --max-heap-table-size arg (=16M)
212+
213+ Don't allow creation of heap tables bigger than this.
214+
215+.. option:: --max-join-size arg (=2147483647)
216+
217+ Joins that are probably going to read more than max_join_size records return
218+ an error.
219+
220+.. option:: --max-length-for-sort-data arg (=1024)
221+
222+ Max number of bytes in sorted records.
223+
224+.. option:: --max-seeks-for-key arg (=18446744073709551615)
225+
226+ Limit assumed max number of seeks when looking up rows based on a key
227+
228+.. option:: --max-sort-length arg (=1024)
229+
230+ The number of bytes to use when sorting BLOB or TEXT values (only the first
231+ max_sort_length bytes of each value are used; the rest are ignored).
232+
233+.. option:: --max-write-lock-count arg (=18446744073709551615)
234+
235+ After this many write locks, allow some read locks to run in between.
236+
237+.. option:: --min-examined-row-limit arg (=0)
238+
239+ Don't log queries which examine less than min_examined_row_limit rows to file.
240+
241+.. option:: --disable-optimizer-prune
242+
243+ Do not apply any heuristic(s) during query optimization to prune, thus
244+ perform an exhaustive search from the optimizer search space.
245+
246+.. option:: --optimizer-search-depth arg (=0)
247+
248+ Maximum depth of search performed by the query optimizer. Values larger than
249+ the number of relations in a query result in better query plans, but take
250+ longer to compile a query. Smaller values than the number of tables in a
251+ relation result in faster optimization, but may produce very bad query plans.
252+ If set to 0, the system will automatically pick a reasonable value; if set to
253+ MAX_TABLES+2, the optimizer will switch to the original find_best (used for
254+ testing/comparison).
255+
256+.. option:: --preload-buffer-size arg (=32768)
257+
258+ The size of the buffer that is allocated when preloading indexes
259+
260+.. option:: --query-alloc-block-size arg (=8192)
261+
262+ Allocation block size for query parsing and execution
263+
264+.. option:: --query-prealloc-size arg (=8192)
265+
266+ Persistent buffer for query parsing and execution
267+
268+.. option:: --range-alloc-block-size arg (=4096)
269+
270+ Allocation block size for storing ranges during optimization
271+
272+.. option:: --read-buffer-size arg (=131072)
273+
274+ Each thread that does a sequential scan allocates a buffer of this size for
275+ each table it scans. If you do many sequential scans, you may want to
276+ increase this value.
277+
278+.. option:: --read-rnd-buffer-size arg (=262144)
279+
280+ When reading rows in sorted order after a sort, the rows are read through
281+ this buffer to avoid a disk seeks. If not set, then it's set to the value of
282+ record_buffer.
283+
284+.. option:: --scheduler arg (=multi-thread)
285+
286+ Select scheduler to be used.
287+
288+.. option:: --sort-buffer-size arg (=2097144)
289+
290+ Each thread that needs to do a sort allocates a buffer of this size.
291+
292+.. option:: --table-definition-cache arg (=128)
293+
294+ The number of cached table definitions.
295+
296+.. option:: --table-open-cache arg (=1024)
297+
298+ The number of cached open tables.
299+
300+.. option:: --table-lock-wait-timeout arg (=50)
301+
302+ Timeout in seconds to wait for a table level lock before returning an error.
303+ Used only if the connection has active cursors.
304+
305+.. option:: --thread-stack arg (=0)
306+
307+ The stack size for each thread. 0 means use OS default.
308+
309+.. option:: --tmp-table-size arg (=16M)
310+
311+ If an internal in-memory temporary table exceeds this size, Drizzle will
312+ automatically convert it to an on-disk MyISAM table.
313+
314
315=== modified file 'docs/protocol.rst'
316--- docs/protocol.rst 2010-09-26 21:24:15 +0000
317+++ docs/protocol.rst 2010-10-04 22:47:14 +0000
318@@ -1,12 +1,10 @@
319-#
320-# Drizzle Client & Protocol Library
321-#
322-# Copyright (C) 2008 Eric Day (eday@oddments.org)
323-# All rights reserved.
324-#
325-# Use and distribution licensed under the BSD license. See
326-# the COPYING file in this directory for full text.
327-#
328+.. Drizzle Client & Protocol Library
329+
330+.. Copyright (C) 2008 Eric Day (eday@oddments.org)
331+.. All rights reserved.
332+
333+.. Use and distribution licensed under the BSD license. See
334+.. the COPYING.BSD file in the root source directory for full text.
335
336 Drizzle Protocol
337 ================
338
339=== modified file 'drizzled/drizzled.cc'
340--- drizzled/drizzled.cc 2010-09-29 17:28:31 +0000
341+++ drizzled/drizzled.cc 2010-10-04 22:47:14 +0000
342@@ -207,7 +207,6 @@
343 static bool opt_debugging= 0;
344 static uint32_t wake_thread;
345 static char *drizzled_chroot;
346-static char *language_ptr;
347 static const char *default_character_set_name;
348 static const char *character_set_filesystem_name;
349 static char *lc_time_names_name;
350@@ -293,8 +292,7 @@
351 char *default_tz_name;
352 char glob_hostname[FN_REFLEN];
353
354-char language[FN_REFLEN],
355- *opt_tc_log_file;
356+char *opt_tc_log_file;
357 const key_map key_map_empty(0);
358 key_map key_map_full(0); // Will be initialized later
359
360@@ -1270,15 +1268,13 @@
361 ("datadir", po::value<string>(),
362 N_("Path to the database root."))
363 ("default-storage-engine", po::value<string>(),
364- N_("Set the default storage engine (table type) for tables."))
365+ N_("Set the default storage engine for tables."))
366 ("default-time-zone", po::value<string>(),
367 N_("Set the default time zone."))
368 ("exit-info,T", po::value<long>(),
369 N_("Used for debugging; Use at your own risk!"))
370 ("gdb", po::value<bool>(&opt_debugging)->default_value(false)->zero_tokens(),
371 N_("Set up signals usable for debugging"))
372- ("language,L", po::value<string>(),
373- N_("(IGNORED)"))
374 ("lc-time-name", po::value<string>(),
375 N_("Set the language used for the month names and the days of the week."))
376 ("log-warnings,W", po::value<string>(),
377@@ -1286,8 +1282,7 @@
378 ("pid-file", po::value<string>(),
379 N_("Pid file used by drizzled."))
380 ("port-open-timeout", po::value<uint32_t>(&drizzled_bind_timeout)->default_value(0),
381- N_("Maximum time in seconds to wait for the port to become free. "
382- "(Default: no wait)"))
383+ N_("Maximum time in seconds to wait for the port to become free. "))
384 ("secure-file-priv", po::value<string>(),
385 N_("Limit LOAD DATA, SELECT ... OUTFILE, and LOAD_FILE() to files "
386 "within specified directory"))
387@@ -1806,10 +1801,6 @@
388 N_("Set up signals usable for debugging"),
389 (char**) &opt_debugging, (char**) &opt_debugging,
390 0, GET_BOOL, NO_ARG, 0, 0, 0, 0, 0, 0},
391- {"language", 'L',
392- N_("(IGNORED)"),
393- (char**) &language_ptr, (char**) &language_ptr, 0, GET_STR, REQUIRED_ARG,
394- 0, 0, 0, 0, 0, 0},
395 {"lc-time-names", OPT_LC_TIME_NAMES,
396 N_("Set the language used for the month names and the days of the week."),
397 (char**) &lc_time_names_name,
398@@ -2152,15 +2143,11 @@
399 /* Things with default values that are not zero */
400 drizzle_home_ptr= drizzle_home;
401 pidfile_name_ptr= pidfile_name;
402- language_ptr= language;
403 session_startup_options= (OPTION_AUTO_IS_NULL | OPTION_SQL_NOTES);
404 refresh_version= 1L; /* Increments on each reload */
405 global_thread_id= 1UL;
406 getSessionList().clear();
407
408- /* Set directory paths */
409- strncpy(language, LANGUAGE, sizeof(language)-1);
410-
411 /* Variables in libraries */
412 default_character_set_name= "utf8";
413 default_collation_name= (char *)compiled_default_collation_name;
414@@ -2251,11 +2238,6 @@
415 vm["user"].as<string>().c_str(), drizzled_user);
416 }
417
418- if (vm.count("language"))
419- {
420- strncpy(language, vm["language"].as<string>().c_str(), sizeof(language)-1);
421- }
422-
423 if (vm.count("version"))
424 {
425 print_version();
426@@ -2382,7 +2364,6 @@
427 pos[0]= FN_LIBCHAR;
428 pos[1]= 0;
429 }
430- internal::convert_dirname(language,language,NULL);
431 (void) internal::my_load_path(drizzle_home, drizzle_home,""); // Resolve current dir
432
433 fs::path pid_file_path(pidfile_name);
434@@ -2403,7 +2384,6 @@
435 strncat(buff, sharedir, sizeof(buff)-strlen(drizzle_home)-1);
436 }
437 internal::convert_dirname(buff,buff,NULL);
438- (void) internal::my_load_path(language,language,buff);
439
440 if (not opt_help)
441 {
442
443=== modified file 'drizzled/set_var.cc'
444--- drizzled/set_var.cc 2010-09-27 14:34:21 +0000
445+++ drizzled/set_var.cc 2010-10-04 22:47:14 +0000
446@@ -317,7 +317,6 @@
447 #define FIXED_VARS_SIZE (sizeof(fixed_vars) / sizeof(drizzle_show_var))
448 static drizzle_show_var fixed_vars[]= {
449 {"back_log", (char*) &back_log, SHOW_INT},
450- {"language", language, SHOW_CHAR},
451 {"pid_file", (char*) pidfile_name, SHOW_CHAR},
452 {"plugin_dir", (char*) opt_plugin_dir, SHOW_CHAR},
453 {"thread_stack", (char*) &my_thread_stack_size, SHOW_INT},
454
455=== modified file 'drizzled/set_var.h'
456--- drizzled/set_var.h 2010-09-27 14:34:21 +0000
457+++ drizzled/set_var.h 2010-10-04 22:47:14 +0000
458@@ -61,7 +61,6 @@
459 extern const char *in_left_expr_name;
460 extern const char *in_additional_cond;
461 extern const char *in_having_cond;
462-extern char language[FN_REFLEN];
463 extern char glob_hostname[FN_REFLEN];
464 extern char drizzle_home[FN_REFLEN];
465 extern char pidfile_name[FN_REFLEN];