Code review comment for lp:~mohyt/drizzle/json_server_schema

Revision history for this message
Stewart Smith (stewart) wrote :

Minor fixes:
- Copyright date should be 2011-2013 rather than just 2011
- It would be good to have a comment in plugin/json_server/ddl/schema.cc that it's mostly just a copy from drizzled/statement/create_schema.cc and friends.
- Where you use a static buffer for processing input (buffer[1024]) please also provide i a test that tests the limits of this buffer to ensure that there are not exploitable buffer overflows.

Questions:
- Why is num_threads set to 1? I don't think this should be here.

Otherwise looks good.

review: Needs Fixing

« Back to merge proposal