~moathahmd/launchpad:master

Last commit made on 2021-12-17
Get this branch:
git clone -b master https://git.launchpad.net/~moathahmd/launchpad
Only Moath Ahmad Ali Alhamaideh can upload to this branch. If you are Moath Ahmad Ali Alhamaideh please log in for upload directions.

Branch merges

Branch information

Name:
master
Repository:
lp:~moathahmd/launchpad

Recent commits

634485f... by Colin Watson

lp.codehosting: Apply "pyupgrade --py3-plus"

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/413400

adb364d... by Colin Watson

Fix ILibraryFileAliasSet.preloadLastDownloaded declaration

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/413402

552baee... by Ioana Lasc

Display expander only when status reports exist for commit

Merged from https://code.launchpad.net/~ilasc/launchpad/+git/launchpad/+merge/413405

4700063... by Ioana Lasc

Display expander only when status reports exist for commit

3cec961... by Colin Watson

Fix ILibraryFileAliasSet.preloadLastDownloaded declaration

It had an extra `self` parameter. `FakeLibrarian` also needs a stub
definition of this method.

15cccd3... by Colin Watson

Add .git-blame-ignore-revs entry

f36fe66... by Colin Watson

lp.codehosting: Apply "pyupgrade --py3-plus"

3192e23... by Colin Watson

Preload more librarian references on Product:+download

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/412706

67c86e3... by Colin Watson

Adjust ObjectSet.__iter__ to avoid pyupgrade confusion

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/413389

33fb8d2... by Colin Watson

Adjust ObjectSet.__iter__ to avoid pyupgrade confusion

pyupgrade rewrites `six.itervalues(dct)` as `dct.values()`, which is
usually correct, but not when returned from an `__iter__` method. That
must return an actual iterator, and returning a view object instead
raises an exception:

  TypeError: iter() returned non-iterator of type 'dict_values'

Fixing this in pyupgrade seems to be hard as the AST walk doesn't have
enough information about ancestor nodes beyond the immediate parent, so
just manually fix the one place in Launchpad where this is a problem so
that pyupgrade can handle other instances of this pattern mechanically.