Code review comment for lp:~mniess/ubuntu/trusty/ibus/fix-lp1240198

Matthias Niess (mniess) wrote :

> At first glance, this seems ok, however, I have two questions:
> 1. is this something suitable for upstreaming and if so, has it been
> upstreamed to ibus or Debian? I think I can see why it would not be, but it
> would be good to have someone explicitly comment

I'm pretty sure this is related to the way Ubuntu uses ibus (which also leads to custom keyboard shortcuts not working) so I would say this is not suitable for upstreaming.

> 2. the patch is against trusty, but per SRU policies
> (https://wiki.ubuntu.com/StableReleaseUpdates) it must first be applied to the
> development release and then applied to a stable release. Can you adjust the
> packaging and test that it works ok in utopic?

I currently have no machine to put utopic on so I cannot test this. I just wanted to help out get this resolved quickly and have this ready for 14.04.2 as it is a huge problem for non-english users. This is especially bad for corporate users who rely on Ubuntu for their work. It is only one dconf setting that was changed in 13.10 and immediately lead to the issue. It should have never made it into 14.04 but it did.

« Back to merge proposal