Code review comment for lp:~mniess/ubuntu/trusty/ibus/fix-lp1240198

Jamie Strandboge (jdstrand) wrote :

At first glance, this seems ok, however, I have two questions:
 1. is this something suitable for upstreaming and if so, has it been upstreamed to ibus or Debian? I think I can see why it would not be, but it would be good to have someone explicitly comment
 2. the patch is against trusty, but per SRU policies ( it must first be applied to the development release and then applied to a stable release. Can you adjust the packaging and test that it works ok in utopic?

review: Needs Fixing

« Back to merge proposal