Akiban Server

Merge lp:~mmcm/akiban-server/security-error-warn into lp:~akiban-technologies/akiban-server/trunk

  1. security-error-warn
  2. Merge into trunk
Proposed by Mike McMahon
Status: Merged
Approved by: Nathan Williams
Approved revision: 2622
Merged at revision: 2622
Proposed branch: lp:~mmcm/akiban-server/security-error-warn
Merge into: lp:~akiban-technologies/akiban-server/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
src/main/java/com/akiban/server/error/ErrorCode.java (+1/-1)
To merge this branch: bzr merge lp:~mmcm/akiban-server/security-error-warn
Reviewer Review Type Date Requested Status
Nathan Williams Approve
Review via email: mp+158821@code.launchpad.net

Description of the change

Make SecurityException logged as ERROR (there is no WARN) not DEBUG.

Even though these can result from bad user input, it is much more likely that there is a configuration error, or possibly even someone creating mischief.

There is a Pivotal story to revise all these levels, but this one seemed worth doing now.

To post a comment you must log in.
Revision history for this message
Nathan Williams (nwilliams) wrote :

As described.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/main/java/com/akiban/server/error/ErrorCode.java'
2--- src/main/java/com/akiban/server/error/ErrorCode.java 2013-04-08 14:53:42 +0000
3+++ src/main/java/com/akiban/server/error/ErrorCode.java 2013-04-14 20:52:25 +0000
4@@ -180,7 +180,7 @@
5 INVALID_ARGUMENT_TYPE ("22", "503", Importance.DEBUG, InvalidArgumentTypeException.class),
6 ZERO_DATE_TIME ("22", "504", Importance.DEBUG, ZeroDateTimeException.class),
7 EXTERNAL_ROW_READER_EXCEPTION ("22", "505", Importance.DEBUG, ExternalRowReaderException.class),
8- SECURITY ("22", "506", Importance.DEBUG, SecurityException.class),
9+ SECURITY ("22", "506", Importance.ERROR, SecurityException.class),
10
11 // Class 23 - integrity constraint violation
12 DUPLICATE_KEY ("23", "501", Importance.DEBUG, DuplicateKeyException.class),

Subscribers

People subscribed via source and target branches