Merge lp:~mmcm/akiban-server/is-full-text-indexes into lp:~akiban-technologies/akiban-server/trunk

Proposed by Mike McMahon
Status: Merged
Approved by: Thomas Jones-Low
Approved revision: 2613
Merged at revision: 2612
Proposed branch: lp:~mmcm/akiban-server/is-full-text-indexes
Merge into: lp:~akiban-technologies/akiban-server/trunk
Diff against target: 57 lines (+7/-3)
2 files modified
src/main/java/com/akiban/server/service/is/BasicInfoSchemaTablesServiceImpl.java (+7/-1)
src/test/java/com/akiban/server/explain/format/DefaultFormatterTest.java (+0/-2)
To merge this branch: bzr merge lp:~mmcm/akiban-server/is-full-text-indexes
Reviewer Review Type Date Requested Status
Thomas Jones-Low Approve
Review via email: mp+157229@code.launchpad.net

Description of the change

Include full text indexes in INFORMATION_SCHEMA.INDEXES.

This appears to be all that's needed to get akdump to output them. It doesn't need any additional information.

To post a comment you must log in.
Revision history for this message
Thomas Jones-Low (tjoneslo) wrote :

It's that simple.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/main/java/com/akiban/server/service/is/BasicInfoSchemaTablesServiceImpl.java'
2--- src/main/java/com/akiban/server/service/is/BasicInfoSchemaTablesServiceImpl.java 2013-03-22 20:05:57 +0000
3+++ src/main/java/com/akiban/server/service/is/BasicInfoSchemaTablesServiceImpl.java 2013-04-04 20:45:28 +0000
4@@ -20,6 +20,7 @@
5 import com.akiban.ais.model.AkibanInformationSchema;
6 import com.akiban.ais.model.CharsetAndCollation;
7 import com.akiban.ais.model.Column;
8+import com.akiban.ais.model.FullTextIndex;
9 import com.akiban.ais.model.GroupIndex;
10 import com.akiban.ais.model.Index;
11 import com.akiban.ais.model.IndexColumn;
12@@ -723,7 +724,7 @@
13 indexType,
14 boolResult(index.isUnique()),
15 index.isGroupIndex() ? index.getJoinType().name() : null,
16- index.isSpatial() ? index.getIndexMethod().name() : null,
17+ (index.getIndexMethod() == Index.IndexMethod.NORMAL) ? null : index.getIndexMethod().name(),
18 ++rowCounter /*hidden pk*/);
19 }
20 }
21@@ -1077,6 +1078,7 @@
22 private final Iterator<UserTable> tableIt;
23 Iterator<TableIndex> tableIndexIt;
24 Iterator<GroupIndex> groupIndexIt;
25+ Iterator<FullTextIndex> textIndexIt;
26 UserTable curTable;
27
28 public IndexIteration(Session session,
29@@ -1094,11 +1096,15 @@
30 return index;
31 }
32 }
33+ while(textIndexIt != null && textIndexIt.hasNext()) {
34+ return textIndexIt.next();
35+ }
36 while(tableIt.hasNext()) {
37 curTable = tableIt.next();
38 if(isAccessible(session, curTable.getName())) {
39 tableIndexIt = curTable.getIndexes().iterator();
40 groupIndexIt = curTable.getGroup().getIndexes().iterator();
41+ textIndexIt = curTable.getOwnFullTextIndexes().iterator();
42 continue getIndexes;
43 }
44 }
45
46=== modified file 'src/test/java/com/akiban/server/explain/format/DefaultFormatterTest.java'
47--- src/test/java/com/akiban/server/explain/format/DefaultFormatterTest.java 2013-03-22 20:05:57 +0000
48+++ src/test/java/com/akiban/server/explain/format/DefaultFormatterTest.java 2013-04-04 20:45:28 +0000
49@@ -58,8 +58,6 @@
50 */
51 @Test
52 public void testDescribe_Explainer() {
53- System.out.println("describe");
54-
55 // copied from TreeFormatTest
56 // parent expresion:
57 // SUBSTRING(FROM_UNIXTIME(123456 * 7 + 8, "%Y-%m-%d"), 9 + 10, 11)

Subscribers

People subscribed via source and target branches