Merge lp:~mmcm/akiban-server/construct-hkey-positions into lp:~akiban-technologies/akiban-server/trunk
Proposed by
Mike McMahon
Status: | Merged |
---|---|
Approved by: | Nathan Williams |
Approved revision: | 2729 |
Merged at revision: | 2728 |
Proposed branch: | lp:~mmcm/akiban-server/construct-hkey-positions |
Merge into: | lp:~akiban-technologies/akiban-server/trunk |
Diff against target: |
138 lines (+122/-0) 2 files modified
src/main/java/com/akiban/server/store/AbstractStore.java (+1/-0) src/test/java/com/akiban/server/test/it/bugs/bug1208930/PartialCascadeHKeyIT.java (+121/-0) |
To merge this branch: | bzr merge lp:~mmcm/akiban-server/construct-hkey-positions |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Nathan Williams | Approve | ||
Review via email: mp+178837@code.launchpad.net |
Description of the change
Fix construction of partially cascading hkeys.
The problem was that the IndexToHKey map was only built when first used. But a running index into the hkey was not initialized at that time. It was therefore wrong in the case where some earlier hkey positions came from the row and a later one from a parent, as in the partial cascading case in the bug report and the new IT.
To post a comment you must log in.
I think all of the fans of lazy evaluation in the AIS may be gone. Removal thoughts?
Looks good.