Merge lp:~mmakonnen/openobject-addons/openobject-addons into lp:openobject-addons

[Michael Telahun Makonnen]

This change fixes a bug I encountered when trying to create a physical inventory from the last nightly build. I configured the warehouse module to keep accounting valuations of my stock and then tried to create an initial inventory. When I reached the validation step I got the following error:
  File "/home/mtm/code/openerp/vendor/openerp-6.2dev-20121122-000101/openerp/addons/account/account.py", line 1442, in create
    c['period_id'] = vals['period_id']
KeyError: 'period_id'

Basically, the problem is that the stock module doesn't specify a financial period or date for the account move line, which then promptly falls flat on its face. If either of these values are not provided it should provide its own values: period_id should default to the current period, date already has a _defaults line which uses the current date so if one isn't specified don't try to set it.

[Andre van Rooyen (klaasvortex)]

Tried your patch/diff. Same result.

File "/opt/openerp/server/openerp/addons/account/account.py", line 1442, in create
    c['period_id'] = vals['period_id'] if 'period_id' in vals else self._get_period(cr, uid, context)
KeyError: 'period_id'

I don't know Python, but is it possible that c['period_id'] does not exists ?
Maybe something (a row) has to be created after setting the realtime option ?

[Michael Telahun Makonnen (mmakonnen)]

Hmmm, I'm not sure what to make of this. The problem is not c['period_id'] as Python will create the key if it does not exist, and the rest of the line is phrased such that vals['period_id'] gets evaluated only if it exists. Can you double check this again and post the full backtrace? Thanks so much for trying out the patch.

=== modified file 'account/account.py'
--- account/account.py	2012-11-15 12:38:51 +0000
+++ account/account.py	2012-11-22 14:28:40 +0000
@@ -1439,9 +1439,9 @@
         if 'line_id' in vals:
             c = context.copy()
             c['novalidate'] = True
-            c['period_id'] = vals['period_id']
+            c['period_id'] = vals['period_id'] if 'period_id' in vals else self._get_period(cr, uid, context)
             c['journal_id'] = vals['journal_id']
-            c['date'] = vals['date']
+            if 'date' in vals: c['date'] = vals['date']
             result = super(account_move, self).create(cr, uid, vals, c)
             self.validate(cr, uid, [result], context)
         else: