Code review comment for lp:~mm-yuhu/gearmand/server-funcs
Revision history for this message
| Brian Aker (brianaker) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
Hi!
On Mar 11, 2010, at 10:36 AM, HackMan wrote:
> I used strcasecmp since this is how the status command was
> implemented. If you want I can rewrite it using a combination of to
> lower and strcmp.
The bigger issue is that if someone tosses a UTF-8 string in, we will
incorrectly lowercase it (which... we aren't perfect on this already).
The test case is more important :)
Cheers,
-Brian