Code review comment for lp:~mluto/mailman/qrunnersleep

Revision history for this message
Mark Sapiro (msapiro) wrote :

This is complicated. With your second change every runner calls _snooze(filecnt) before exiting. This means that the "for qrunner in qrunners:" loop in bin/qrunner doesn't complete until every runner exits which in the case of RetryRunner is 15 minutes, so that's not acceptable.

Yet with the initial change, the "for qrunner in qrunners:" loop runs after sleeping only QRUNNER_SLEEP_TIME which means RetryRunner runs that often. I suppose that is not a serious issue because the actual retries are controlled by DELIVERY_RETRY_WAIT, at least since 2.1.26.

« Back to merge proposal